Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mnt nist tests #2921

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Mnt nist tests #2921

merged 2 commits into from
Jan 8, 2024

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Jan 8, 2024

I'm not exactly sure what's going on. The tests pass with this patch, but if I run the query in a separate ipython, I get different results. Any ideas @keflavich?

In [55]: result = Nist.query(4000 * u.nm, 7000 * u.nm)

In [56]: set(result['TP'].filled())
Out[56]: {np.str_('N/A'), np.str_('T7651'), np.str_('T7771'), np.str_('T8637')}

@keflavich
Copy link
Contributor

I saw this error too but have no understanding of it. If/when I dig further into #2920, I'll have a closer look at this

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f63cd84) 67.30% compared to head (ae50f61) 67.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2921   +/-   ##
=======================================
  Coverage   67.30%   67.30%           
=======================================
  Files         235      235           
  Lines       18135    18135           
=======================================
  Hits        12206    12206           
  Misses       5929     5929           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bsipocz
Copy link
Member Author

bsipocz commented Jan 8, 2024

This PR makes pytest astroquery/nist/tests/test_nist_remote.py::TestNist::test_query -R pass, so would recommend merging, but getting different results whether pytest was involved or not should be investigated as part of #2920

@bsipocz bsipocz merged commit e52e788 into astropy:main Jan 8, 2024
10 checks passed
@bsipocz
Copy link
Member Author

bsipocz commented Jan 8, 2024

I actually opened #2922 to track this bug/mystery

@bsipocz bsipocz deleted the MNT_nist_tests branch January 26, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants