-
-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature simbad query tap #2856
Merged
+887
−82
Merged
Feature simbad query tap #2856
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
eb79ed7
FEAT: Add a query_tap method to SimbadClass
ManonMarchand e6580a8
docs: reorganize sections in simbad docs
ManonMarchand ab7c7d2
docs: add query TAP section
ManonMarchand f003c5d
feat: add helper functions to explore SIMBAD tables
ManonMarchand fca6d15
docs: add documentation for query_tap and its helper methods
ManonMarchand 14fe47d
test: add tests for _adql_parameter and _adql_name
ManonMarchand 9076760
docs: add changelog entry
ManonMarchand 6d31b1f
test: add try/except on pyvo version for DALOverflowWarning
ManonMarchand 564517a
fix: exchange order of BaseVOQuery and SimbadBaseQuery
ManonMarchand 96777c1
refactor: rename tables and columns into list_tables and list_columns
ManonMarchand 67aab66
style: make optional kwargs kwarg only
ManonMarchand cc3aeab
docs: remove links to issues, rephrase adql example
ManonMarchand 21ccd2b
docs: remove doctest ignore on first TAP example
ManonMarchand 744262f
feat: add caching to query_tap and hardlimit
ManonMarchand 821aec7
docs: add an example of Simbad.query_tap with an uploaded table
ManonMarchand 8ff6d73
fix: remove use of functools.cache_property for python 3.7 support
ManonMarchand 4983ab6
fix: switch simbad.mirror list into simbad.conf.server_list
ManonMarchand 79d4010
docs: fix english issues
ManonMarchand 56c8e1d
docs: increase font size in simbad graph
ManonMarchand b99ad4c
fix: updated datatype in doctest outputs
ManonMarchand d2b2bc4
edit intersphinx links
ManonMarchand 1304824
fix: simplify IN statement
ManonMarchand ccf93cb
fix: remove unused adql_name function
ManonMarchand File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: remove use of functools.cache_property for python 3.7 support
commit 8ff6d7368adcd01286f52978a47e135cfad355af
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh, reminder that we should indeed drop support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I keep the comment to help when the support will be dropped, or is it noise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do keep comments like these. Whenever we drop support I usually go around grep for things like
3.7
, etc, so will more likely to find this for cleanup because of the comment.