Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing CI hiccups from astroquery.mast unit test #2729

Closed
wants to merge 1 commit into from

Conversation

jaymedina
Copy link
Contributor

@jaymedina jaymedina commented May 5, 2023

Summary

The dev dependency test was failing due to an error in the computation of the offset between the resolved object and its sky coordinates from the literature. It was infinitesimally small, something like 10**-15, so I rounded it to the neares 10**-10.

Task List

  • Rounded value to nearest 10th decimal place to fix systematic error in offset computation (astroquery/mast/test_mast.py)

@jaymedina jaymedina marked this pull request as draft May 5, 2023 17:30
@jaymedina jaymedina self-assigned this May 5, 2023
@jaymedina jaymedina changed the title rounded value to nearest 10th decimal place to fix systematic error i… Fixing CI hiccups from astroquery.mast unit test and docs May 5, 2023
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #2729 (5505f7f) into main (011c3dc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2729   +/-   ##
=======================================
  Coverage   65.85%   65.85%           
=======================================
  Files         233      233           
  Lines       17896    17896           
=======================================
  Hits        11785    11785           
  Misses       6111     6111           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jaymedina jaymedina changed the title Fixing CI hiccups from astroquery.mast unit test and docs Fixing CI hiccups from astroquery.mast unit test May 5, 2023
@jaymedina
Copy link
Contributor Author

I fixed the dev dependency error but I'm actually not sure why the readthedocs is failing. The error message at the top is suggesting there could be a dependency conflict in astroquery? @keflavich https://readthedocs.org/projects/astroquery/builds/20444648/

@keflavich
Copy link
Contributor

keflavich commented May 5, 2023

I don't know what to do about this - it looks like a deep incompatibility in the urllib3 module in ssl, but that is something at the python level... and we can't upgrade (rtd is only py<3.8).

EDIT: there's a version update on rtd's config; I think I've got it. Once #2730 is done, we can rebase against that.

@jaymedina jaymedina deleted the fix-ci branch May 5, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants