Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vizier default url #2700

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Update vizier default url #2700

merged 2 commits into from
Apr 4, 2023

Conversation

keflavich
Copy link
Contributor

as recommended in #2699 (comment)

@codecov
Copy link

codecov bot commented Apr 4, 2023 •
edited
Loading

Codecov Report

Merging #2700 (1e38c1a) into main (dfb7549) will not change coverage.
The diff coverage is n/a.

❗ Current head 1e38c1a differs from pull request most recent head fdbc216. Consider uploading reports for the commit fdbc216 to get more accurate results

@@           Coverage Diff           @@
##             main    #2700   +/-   ##
=======================================
  Coverage   65.74%   65.74%           
=======================================
  Files         233      233           
  Lines       17842    17842           
=======================================
  Hits        11731    11731           
  Misses       6111     6111
Impacted Files Coverage Δ
astroquery/vizier/__init__.py 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

bsipocz
bsipocz approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cds is needed for the url, or we would do a redirect again. Also, no need to list the old address.

astroquery/vizier/__init__.py Outdated Show resolved Hide resolved
@bsipocz bsipocz added this to the v0.4.7 milestone Apr 4, 2023
@bsipocz bsipocz linked an issue Apr 4, 2023 that may be closed by this pull request
Empty lines in some Vizier queries #2699
Closed
@bsipocz bsipocz removed a link to an issue Apr 4, 2023
Empty lines in some Vizier queries #2699
Closed
@bsipocz bsipocz merged commit 8e8c106 into astropy:main Apr 4, 2023
@bsipocz bsipocz mentioned this pull request Apr 13, 2023
Closed
@ManonMarchand ManonMarchand mentioned this pull request Sep 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsipocz bsipocz bsipocz approved these changes

Assignees
No one assigned
Labels
no-changelog-entry-needed vizier
Projects
None yet
Milestone
v0.4.7
Development

Successfully merging this pull request may close these issues.
2 participants
@keflavich @bsipocz