Remove all uses of cgi
#2657
Merged
Remove all uses of cgi
#2657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `cgi` module from the Python standard library is deprecated as of Python 3.11, see PEP 594: https://peps.python.org/pep-0594/ All uses of `cgi` in `astroquery` have been replaced following the example provided in the PEP.
Codecov Report
@@ Coverage Diff @@
## main #2657 +/- ##
=======================================
Coverage 68.87% 68.87%
=======================================
Files 304 304
Lines 22529 22531 +2
=======================================
+ Hits 15516 15518 +2
Misses 7013 7013
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thanks @eerovaher for doing this , I will have a look at this and check if everything works as expeced. |
bsipocz
approved these changes
Apr 28, 2023
|
Thanks @eerovaher! |
|
Thanks @eerovaher and @bsipocz ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cgimodule from the Python standard library is deprecated as of Python 3.11, see PEP 594. This pull request replaces all uses ofcgiinastroqueryfollowing the example provided in the PEP.Closes #2628