Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated function send_request() #2583

Merged
merged 2 commits into from
Nov 16, 2022

Conversation

AlinderS
Copy link
Contributor

Removed code deprecated in 910791c more than a year ago.
Also removed tests and monkeypatched test functions in xmatch which were not doing anything.

@AlinderS AlinderS force-pushed the remove-deprecated-code branch from b7af7e9 to 25c1f5a Compare November 14, 2022 15:53
@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #2583 (25c1f5a) into main (31842df) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 25c1f5a differs from pull request most recent head 855d19b. Consider uploading reports for the commit 855d19b to get more accurate results

@@            Coverage Diff             @@
##             main    #2583      +/-   ##
==========================================
- Coverage   64.08%   64.05%   -0.04%     
==========================================
  Files         131      131              
  Lines       16927    16907      -20     
==========================================
- Hits        10847    10829      -18     
+ Misses       6080     6078       -2     
Impacted Files Coverage Δ
astroquery/utils/commons.py 75.14% <100.00%> (-1.58%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bsipocz bsipocz added this to the v0.4.7 milestone Nov 14, 2022
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would need a changelog entry, otherwise looks all good (see examples for other removed functionality for the wording).

Thanks, @AlinderS!

@bsipocz bsipocz merged commit b1805f6 into astropy:main Nov 16, 2022
@bsipocz
Copy link
Member

bsipocz commented Nov 16, 2022

Thanks @AlinderS!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants