Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Adding online CI job for windows #2527

Merged
merged 2 commits into from
Sep 13, 2022
Merged

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Sep 13, 2022

This PR adds another remote-data cron job, this time to run it on windows. I'm not certain that it will smoke out all issues (#2526 (comment)), but will be better than nothing.

I'm temporarily running this windows job here, so we can have one run for smoking out issues. Once CI is finished with this (the online jobs will fail), I'll revert back this to be cron only and merge.

Then we start working with the log and fix possible path issues.

cc @eerovaher

@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #2527 (c56d802) into main (1ff3b7f) will not change coverage.
The diff coverage is n/a.

❗ Current head c56d802 differs from pull request most recent head 48f0131. Consider uploading reports for the commit 48f0131 to get more accurate results

@@           Coverage Diff           @@
##             main    #2527   +/-   ##
=======================================
  Coverage   63.08%   63.08%           
=======================================
  Files         133      133           
  Lines       17313    17313           
=======================================
  Hits        10922    10922           
  Misses       6391     6391           
Impacted Files Coverage Δ
astroquery/esa/hubble/core.py 86.47% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bsipocz bsipocz marked this pull request as ready for review September 13, 2022 18:34
@bsipocz bsipocz force-pushed the ci_add_windows_cron branch from 201f15e to bf12a20 Compare September 13, 2022 18:35
@bsipocz bsipocz force-pushed the ci_add_windows_cron branch from bf12a20 to c56d802 Compare September 13, 2022 18:48
@bsipocz bsipocz merged commit 404fa41 into astropy:main Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant