Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding warning about non-functioning NRAO module #2387

Merged
merged 2 commits into from
May 3, 2022

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented May 3, 2022

I suggest putting on a 6-months duration for this warning and removing the module after that, unless the updates as per #2316 are done by then.

I don't add a changelog now but also leave off the label, the non-functioning of the module needs to be mentioned if this ends up in a release without the updates PR.

@bsipocz bsipocz added the nrao label May 3, 2022
@bsipocz bsipocz added this to the v0.4.7 milestone May 3, 2022
@bsipocz bsipocz requested a review from keflavich May 3, 2022 00:18
@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #2387 (d6dbc7c) into main (5ac1834) will decrease coverage by 0.45%.
The diff coverage is n/a.

❗ Current head d6dbc7c differs from pull request most recent head 3917092. Consider uploading reports for the commit 3917092 to get more accurate results

@@            Coverage Diff             @@
##             main    #2387      +/-   ##
==========================================
- Coverage   63.29%   62.84%   -0.46%     
==========================================
  Files         132      133       +1     
  Lines       17256    17270      +14     
==========================================
- Hits        10923    10853      -70     
- Misses       6333     6417      +84     
Impacted Files Coverage Δ
astroquery/nrao/core.py 24.57% <ø> (-46.46%) ⬇️
astroquery/utils/cleanup_downloads.py 80.00% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@keflavich keflavich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor language nitpick; 👍 otherwise

astroquery/nrao/__init__.py Outdated Show resolved Hide resolved
Co-authored-by: Adam Ginsburg <keflavich@gmail.com>
@bsipocz bsipocz merged commit 84a229c into astropy:main May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants