Large crossid queries #2305
Merged
Large crossid queries #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 23, 2022
Closed
Codecov Report
@@ Coverage Diff @@
## main #2305 +/- ##
=======================================
Coverage 62.97% 62.97%
=======================================
Files 131 131
Lines 16922 16923 +1
=======================================
+ Hits 10656 10657 +1
Misses 6266 6266
Continue to review full report at Codecov.
|
keflavich
approved these changes
Feb 24, 2022
bsipocz
force-pushed
the
large_crossid_queries
branch
from
9157024 to
2a4befe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the rebased and updated version of #589
It has been put on top of #2304 in order to get all tests, local and remote pass.
The logic in this PR should work for #2211, too, but it would need a bit more rewrite of SQL generating code, so it's beyond the scope of this current PR.