Expand contribution guidelines #2248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2248 +/- ##
==========================================
+ Coverage 62.38% 62.40% +0.02%
==========================================
Files 131 131
Lines 16775 16777 +2
==========================================
+ Hits 10465 10470 +5
+ Misses 6310 6307 -3
Continue to review full report at Codecov.
|
eerovaher
reviewed
Dec 13, 2021
CONTRIBUTING.rst
Outdated
Comment on lines
68
to
69
| For example, astropy.table should be used for table handling, | ||
| astropy.io.ascii for ascii-table parsing, and astropy.units for unit and quantity |
There was a problem hiding this comment.
It would be convenient to have links to relevant astropy documentation:
Suggested change
| For example, astropy.table should be used for table handling, | |
| astropy.io.ascii for ascii-table parsing, and astropy.units for unit and quantity | |
| For example, `astropy.table` should be used for table handling, | |
| `astropy.io.ascii` for ascii-table parsing, and `astropy.units` for unit and quantity |
There was a problem hiding this comment.
👍 - I think we have to link manually, though, not through intersphinx, b/c CONTRIBUTING is rendered by github
Co-authored-by: Eero Vaher <eero.vaher@gmail.com>
bsipocz
reviewed
Dec 16, 2021
bsipocz
approved these changes
Dec 16, 2021
Co-authored-by: Brigitta Sipőcz <b.sipocz@gmail.com>
|
Thanks @keflavich! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our contributing guidelines were not explicit about dependencies and timing of PRs, so I suggest we expand those guidelines.