Add more units to nasa_exoplanet_archive unit mapper

[bsipocz]

This should get rid of the unit related warnings that are turned to errors in the test suite.

@rickynilsson - please do double-check whether all of these are correct. E.g. the column definition table (https://exoplanetarchive.ipac.caltech.edu/docs/API_PS_columns.html) uses both log and log10 units are those indeed both base 10 logs? There is some disagreement with the table that is returned, as e.g. for column st_logg the returned unit is 'log(cm/s**2)' while in the definition table it's 'log10(cm/s**2)'. OTOH st_lum is 'log(Solar)' at both places.

I've also slightly modified the warning which may result in more warnings for users (as previously it was one per unit, but now there will be one for each column that has unrecognised units, even if that unit is the same for multiple columns. However, printing the column out helps a lot during debugging to find the column description on the definition page).

[codecov]

Codecov Report

Merging #2218 (0bc3021) into main (1b241d5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2218   +/-   ##
=======================================
  Coverage   61.80%   61.80%           
=======================================
  Files         129      129           
  Lines       16286    16286           
=======================================
  Hits        10065    10065           
  Misses       6221     6221           

Impacted Files	Coverage Δ
...roquery/ipac/nexsci/nasa_exoplanet_archive/core.py	68.87% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b241d5...0bc3021. Read the comment docs.

[rickynilsson]

This should get rid of the unit related warnings that are turned to errors in the test suite.

@rickynilsson - please do double-check whether all of these are correct. E.g. the column definition table (https://exoplanetarchive.ipac.caltech.edu/docs/API_PS_columns.html) uses both log and log10 units are those indeed both base 10 logs? There is some disagreement with the table that is returned, as e.g. for column st_logg the returned unit is 'log(cm/s**2)' while in the definition table it's 'log10(cm/s**2)'. OTOH st_lum is 'log(Solar)' at both places.

@bsipocz - those units should both be base 10 logs. Thanks for noting that. We will relabel to 'log10(Solar)', and should also make sure the returned unit for st_logg is 'log10(cm/s**2)'.

I've also slightly modified the warning which may result in more warnings for users (as previously it was one per unit, but now there will be one for each column that has unrecognised units, even if that unit is the same for multiple columns. However, printing the column out helps a lot during debugging to find the column description on the definition page).

Sounds good to me!

[bsipocz]

those units should both be base 10 logs. Thanks for noting that. We will relabel to 'log10(Solar)', and should also make sure the returned unit for st_logg is 'log10(cm/s**2)'.

right now we parse both of those as log10, hopefully, that assumption stays correct for the future, too.