[BUG] update column name parsing to fix KeyError in JplHorizons #2202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2202 +/- ##
=======================================
Coverage 66.11% 66.11%
=======================================
Files 418 418
Lines 28180 28180
=======================================
Hits 18631 18631
Misses 9549 9549
Continue to review full report at Codecov.
|
|
I'm going ahead and merge this for the sake of the new release. If there is anything wrong/suboptimal with the PR, please do open a follow-up one. |
|
@bsipocz Oh, sorry to miss this! (but it looks fine anyway) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix all the currently failing remote tests.
This should fix #2169, @mkelley - please check that indeed all the cited upstream changes has been addressed if necessary in the module with your previous PR.