Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix simbad remote tests #2199

Merged
merged 4 commits into from
Nov 13, 2021
Merged

Fix simbad remote tests #2199

merged 4 commits into from
Nov 13, 2021

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Nov 11, 2021

Some of these failures are red herring regarding the module and related to changes to the logging system (see discussion in #2195). As a workaround, I opted to use the same temp directory approach as we have in some other modules.

The remaining test failures were then due to some more timeouts as the ROW_LIMIT were not inherited properly in the new instances.

Fixes: #2195

@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #2199 (5773ea7) into main (75cfd69) will decrease coverage by 0.10%.
The diff coverage is 40.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2199      +/-   ##
==========================================
- Coverage   66.10%   65.99%   -0.11%     
==========================================
  Files         418      418              
  Lines       28167    28232      +65     
==========================================
+ Hits        18619    18633      +14     
- Misses       9548     9599      +51     
Impacted Files Coverage Δ
astroquery/simbad/tests/test_simbad_remote.py 22.72% <29.35%> (-7.36%) ⬇️
astroquery/query.py 58.87% <80.00%> (+0.46%) ⬆️
astroquery/simbad/core.py 89.73% <90.00%> (+0.06%) ⬆️
astroquery/simbad/tests/test_simbad.py 98.35% <100.00%> (+0.02%) ⬆️
astroquery/utils/commons.py 78.78% <0.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f18f02b...5773ea7. Read the comment docs.

@bsipocz bsipocz mentioned this pull request Nov 12, 2021
28 tasks
@bsipocz
Copy link
Member Author

bsipocz commented Nov 13, 2021

Let's get these test workarounds in, so we produce fewer false failures.

@bsipocz bsipocz merged commit 2f3dbcb into astropy:main Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote tests fail for simbad
1 participant