-
-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sdss documentaion cleanup #1977
Conversation
ad850b5
to
52bc625
Compare
I've rebased this but see remote data failures with the docs, so changed I changed the status back to draft. |
Codecov Report
@@ Coverage Diff @@
## main #1977 +/- ##
=======================================
Coverage 62.82% 62.82%
=======================================
Files 130 130
Lines 16848 16848
=======================================
Hits 10584 10584
Misses 6264 6264 Continue to review full report at Codecov.
|
52bc625
to
9472e6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased, and confirmed that tests pass when remote-data is allowed.
I see an SDSS remote test failure, but that is totally unrelated to this PR, so I go ahead and merge it. Thank you @tinumide and @ceb8! |
@bsipocz Yeah, I didn't fix that. I'm planning a go through of the remotes tests to collect failures and fix/make issues when I've finished getting these docs PRs through. |
Yeah, no worries we have plenty of them still (sadly), I suppose it's time to update #2203 with the current status. |
No description provided.