Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sdss documentaion cleanup #1977

Merged
merged 2 commits into from
Feb 22, 2022
Merged

Conversation

tinuademargaret
Copy link
Contributor

No description provided.

@astropy-bot astropy-bot bot added the sdss label Feb 2, 2021
@tinuademargaret tinuademargaret added this to the v0.4.2 milestone Feb 2, 2021
@bsipocz bsipocz modified the milestones: v0.4.2, v0.4.3 May 15, 2021
@bsipocz bsipocz removed this from the v0.4.3 milestone Jul 7, 2021
@bsipocz bsipocz marked this pull request as draft February 19, 2022 04:20
@bsipocz bsipocz requested a review from ceb8 February 19, 2022 04:21
@bsipocz
Copy link
Member

bsipocz commented Feb 19, 2022

I've rebased this but see remote data failures with the docs, so changed I changed the status back to draft.

@codecov
Copy link

codecov bot commented Feb 19, 2022

Codecov Report

Merging #1977 (9472e6a) into main (5e9b817) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1977   +/-   ##
=======================================
  Coverage   62.82%   62.82%           
=======================================
  Files         130      130           
  Lines       16848    16848           
=======================================
  Hits        10584    10584           
  Misses       6264     6264           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e9b817...9472e6a. Read the comment docs.

@ceb8 ceb8 added this to the v0.4.6 milestone Feb 22, 2022
@ceb8 ceb8 marked this pull request as ready for review February 22, 2022 22:44
Copy link
Member

@ceb8 ceb8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased, and confirmed that tests pass when remote-data is allowed.

@bsipocz
Copy link
Member

bsipocz commented Feb 22, 2022

I see an SDSS remote test failure, but that is totally unrelated to this PR, so I go ahead and merge it. Thank you @tinumide and @ceb8!

@bsipocz bsipocz merged commit 27ce5ce into astropy:main Feb 22, 2022
@bsipocz bsipocz added the sdss label Feb 22, 2022
@ceb8
Copy link
Member

ceb8 commented Feb 22, 2022

@bsipocz Yeah, I didn't fix that. I'm planning a go through of the remotes tests to collect failures and fix/make issues when I've finished getting these docs PRs through.

@bsipocz
Copy link
Member

bsipocz commented Feb 22, 2022

Yeah, no worries we have plenty of them still (sadly), I suppose it's time to update #2203 with the current status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants