Skip to content

Commit

Permalink
Merge pull request #2656 from nkphysics/nvas-kwarg-refactor
Browse files Browse the repository at this point in the history
Refactor: Made NVAS optional kwargs keyword only
  • Loading branch information
bsipocz authored Feb 8, 2023
2 parents 4b29a35 + 957aca4 commit 766a4fc
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
5 changes: 5 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,11 @@ nist

- Optional parameters in all methods are kwargs keyword only. [#2655]

nvas
^^^^

- Made NVAS optional kwargs keyword only. [#2656]

oac
^^^

Expand Down
8 changes: 4 additions & 4 deletions astroquery/nvas/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class NvasClass(BaseQuery):
"D": (110, 170),
}

def get_images(self, coordinates, radius=0.25 * u.arcmin, max_rms=10000,
def get_images(self, coordinates, *, radius=0.25 * u.arcmin, max_rms=10000,
band="all", get_uvfits=False, verbose=True,
get_query_payload=False, show_progress=True):
"""
Expand Down Expand Up @@ -82,7 +82,7 @@ def get_images(self, coordinates, radius=0.25 * u.arcmin, max_rms=10000,

return filelist

def get_images_async(self, coordinates, radius=0.25 * u.arcmin,
def get_images_async(self, coordinates, *, radius=0.25 * u.arcmin,
max_rms=10000, band="all", get_uvfits=False,
verbose=True, get_query_payload=False,
show_progress=True):
Expand Down Expand Up @@ -136,7 +136,7 @@ def get_images_async(self, coordinates, radius=0.25 * u.arcmin,
show_progress=show_progress)
for U in image_urls]

def get_image_list(self, coordinates, radius=0.25 * u.arcmin,
def get_image_list(self, coordinates, *, radius=0.25 * u.arcmin,
max_rms=10000, band="all", get_uvfits=False,
get_query_payload=False):
"""
Expand Down Expand Up @@ -191,7 +191,7 @@ def get_image_list(self, coordinates, radius=0.25 * u.arcmin,
get_uvfits=get_uvfits)
return image_urls

def extract_image_urls(self, html_in, get_uvfits=False):
def extract_image_urls(self, html_in, *, get_uvfits=False):
"""
Helper function that uses regexps to extract the image urls from the
given HTML.
Expand Down

0 comments on commit 766a4fc

Please sign in to comment.