Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Skip CI natively, DOC: Update license year #11316

Merged
merged 2 commits into from
Feb 10, 2021

Conversation

pllim
Copy link
Member

@pllim pllim commented Feb 9, 2021

Description

Supposedly, this should Just Work ™️ now...

https://github.blog/changelog/2021-02-08-github-actions-skip-pull-request-and-push-workflows-with-skip-ci/

Direct follow-up of #11168 and #11274 . Also see #11038

Also updated license year, because I needed a second commit to make sure it doesn't skip when second commit doesn't have the directive. Might as well put in a real change, right? Seems to work!

Pros

  • Uses built-in functionality, hence reducing our maintenance burden.
  • Does not even start any jobs, hence appears to be more eco-friendly (not quantified).

Cons

For the first two points in Cons, let's see how actions/runner#976 goes. For the last two points, we might just have to live with it or have a way to scrub out trigger directive from the merge commit message before merge (is that even possible without much pain?).

@pllim pllim added this to the v4.3 milestone Feb 9, 2021
@pllim
Copy link
Member Author

pllim commented Feb 9, 2021

Oooo... it doesn't even kick off, saving even more CPU cycles!

p.s. Not sure why CircleCI is running but that is out of scope.

@pllim pllim changed the title TST: Skip CI natively TST: Skip CI natively, DOC: Update license year Feb 9, 2021
@pllim
Copy link
Member Author

pllim commented Feb 9, 2021

Noticed some drawbacks. I will summarize in the original post above.

@pllim pllim mentioned this pull request Feb 9, 2021
18 tasks
@pllim pllim requested a review from saimn February 9, 2021 19:54
pllim added a commit to spacetelescope/corazon that referenced this pull request Feb 9, 2021
pllim added a commit to spacetelescope/exovetter that referenced this pull request Feb 9, 2021
pllim added a commit to pllim/jwst that referenced this pull request Feb 9, 2021
pllim added a commit to spacetelescope/synphot_refactor that referenced this pull request Feb 9, 2021
pllim added a commit to spacetelescope/stsynphot_refactor that referenced this pull request Feb 9, 2021
pllim added a commit to spacetelescope/stginga that referenced this pull request Feb 9, 2021
pllim added a commit to spacetelescope/stsci.tools that referenced this pull request Feb 9, 2021
pllim added a commit to spacetelescope/acstools that referenced this pull request Feb 9, 2021
pllim added a commit to spacetelescope/reftools that referenced this pull request Feb 9, 2021
pllim added a commit to spacetelescope/wss_tools that referenced this pull request Feb 9, 2021
@saimn
Copy link
Contributor

saimn commented Feb 10, 2021

As you said there is no way to disable this, so I guess we should merge and see how it works for merge commits, cron etc.

@pllim
Copy link
Member Author

pllim commented Feb 10, 2021

Yeah. The way they phrased it though, cron job might be unaffected. We will see about merge in a minute.

Others are complaining too and asking about opting in/out, so we'll see...

@pllim pllim merged commit 74d445c into astropy:master Feb 10, 2021
@pllim pllim deleted the use-builtin-skip-ci branch February 10, 2021 14:40
@pllim
Copy link
Member Author

pllim commented Feb 10, 2021

Update: Merge commit message only has the PR title, so CI is running. There is still an edge case of what if someone put the directly in PR title but that is so rare (and discouraged) that it isn't really an issue. Seeing this, cron probably will be okay too, since we rarely push directly into master with any skip directive, if at all.

jdavies-st pushed a commit to spacetelescope/jwst that referenced this pull request Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants