-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Skip CI natively, DOC: Update license year #11316
Conversation
Oooo... it doesn't even kick off, saving even more CPU cycles! p.s. Not sure why CircleCI is running but that is out of scope. |
Noticed some drawbacks. I will summarize in the original post above. |
As you said there is no way to disable this, so I guess we should merge and see how it works for merge commits, cron etc. |
Yeah. The way they phrased it though, cron job might be unaffected. We will see about merge in a minute. Others are complaining too and asking about opting in/out, so we'll see... |
Update: Merge commit message only has the PR title, so CI is running. There is still an edge case of what if someone put the directly in PR title but that is so rare (and discouraged) that it isn't really an issue. Seeing this, cron probably will be okay too, since we rarely push directly into |
Description
Supposedly, this should Just Work ™️ now...
https://github.blog/changelog/2021-02-08-github-actions-skip-pull-request-and-push-workflows-with-skip-ci/
Direct follow-up of #11168 and #11274 . Also see #11038
Also updated license year, because I needed a second commit to make sure it doesn't skip when second commit doesn't have the directive. Might as well put in a real change, right? Seems to work!
Pros
Cons
.github/workflows
, including labeler and triage actions, which is undesirable.Might also skip a merge commit inSee TST: Skip CI natively, DOC: Update license year #11316 (comment)master
when PR is merged if the merge commit message collates all PR commit messages into one, and one or more of the PR commits had the trigger in it.Might also skip a cron job run if the last commit inSee TST: Skip CI natively, DOC: Update license year #11316 (comment)master
is a message with the trigger.For the first two points in Cons, let's see how actions/runner#976 goes. For the last two points, we might just have to live with it or have a way to scrub out trigger directive from the merge commit message before merge (is that even possible without much pain?).