-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin numpy to 2.0.0rc1 #16
Conversation
I'm trying to get reproject to work and have released new wheels but that job is still failing as it requires a new release of astropy-healpix. This is in preparation in astropy/astropy-healpix#214 but running into issues related to |
asdf-astropy -- I think @braingram is aware of this. But just in case: |
For completeness, I cross-linked related issues in the original post above. Hope you don't mind. Thanks! |
That's fantastic, thank you! |
I've restarted the CI to check where things stand right now. |
Restarted again |
Thanks ! I see ccdproc is still not caught up, I'll get back to it ! |
@astrofrog if you'd like to keep the PR description updated, here's the latest (and last) patch needed for ccdproc astropy/ccdproc#824 Also worth noting that it depends on astroscrappy, which Simon in working on in astropy/astroscrappy#85 |
Also, I wanted to double check on specreduce and it doesn't just need photutils: the test suite also requires a new release for |
Thanks for the update! I guess I have to release synphot sooner than later... Update: Released 1.4.0 |
Some downstream packages like
|
I should have time to do a |
I think we're almost there. Should we omit |
I merged #17 . Please rebase to ensure sunpy is now green. Thanks! |
Rebased! |
sunpy release has not got the numpy fixes yet. We need to get 5.1.3 out. sunpy-dev still is not skipping the figure tests. I wonder if there is a problem in the pytest config? |
Actually I think those sunpy dev issues might be on us but I am investigating. |
For sunpy dev I opened: #18 it points to my branch that I hope to merge but it shows sunpy-dev passing under numpy2.0rc now (that last commit needs to go before a merge) |
Ok so the remaining issues for the CI to turn green are:
None of the issues appear to be related to astropy 6.1 so we should be safe to go ahead and do a release I think. |
Any of these diff actually need to be merged for next time? If not, we can close the PR without merge. Thanks! |
Looks like bottleneck have an rc out with numpy 2.0 support, so trying to re-run |
Seems like I missed a spot when I worked on ccdproc, however, the one remaining failure doesn't affect users, and its fixed in astropy/ccdproc#829 |
Everything is green except for ccdproc stable which makes sense since it requires astropy/ccdproc#829 which hasn't been released yet (and is not urgent since doesn't affect users). I think we can close this now! |
Thanks! |
Some packages are forcing numpy<2 to be installed, so pinning numpy to 2.0.0rc1 to see what works and what doesn't. Not for merging at this point!
Where the wild things are
copy
usage inQuantity
converter to deal with astropy 6.1 changes asdf-astropy#224