Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default_columns property from hats catalog if available in read_hats #543

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

smcguire-cmu
Copy link
Contributor

@smcguire-cmu smcguire-cmu commented Jan 22, 2025

Uses the property added in response to #529 when loading a hats catalog

Closes #267

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.34%. Comparing base (1c5c44f) to head (8ae02d8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #543   +/-   ##
=======================================
  Coverage   97.34%   97.34%           
=======================================
  Files          43       43           
  Lines        1732     1734    +2     
=======================================
+ Hits         1686     1688    +2     
  Misses         46       46           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 22, 2025

Before [abfeb5d] After [2bd02a4] Ratio Benchmark (Parameter)
12.4±0.02s 12.5±0.06s 1.01 benchmarks.time_create_large_catalog
1.84±0.01s 1.85±0.03s 1.01 benchmarks.time_create_midsize_catalog
13.9±0.2ms 13.7±0.2ms 0.99 benchmarks.time_box_filter_on_partition
80.8±0.9ms 80.3±0.8ms 0.99 benchmarks.time_kdtree_crossmatch
27.0±0.2ms 26.5±0.7ms 0.98 benchmarks.time_polygon_search

Click here to view all benchmarks.

smcguire-cmu and others added 2 commits January 23, 2025 13:22
Co-authored-by: Melissa DeLucchi <113376043+delucchi-cmu@users.noreply.github.com>
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@smcguire-cmu smcguire-cmu merged commit 0985d0d into main Jan 23, 2025
11 checks passed
@smcguire-cmu smcguire-cmu deleted the sean/use-default-cols branch January 23, 2025 21:08
@delucchi-cmu delucchi-cmu mentioned this pull request Jan 24, 2025
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read catalog - get only positional coordinates by default
2 participants