Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more helpful error with non overlapping catalogs #537

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

smcguire-cmu
Copy link
Contributor

@smcguire-cmu smcguire-cmu commented Jan 7, 2025

Fixes #512

Copy link

github-actions bot commented Jan 7, 2025

Before [965ef8f] After [8e265da] Ratio Benchmark (Parameter)
14.1±0.4ms 14.3±0.2ms 1.01 benchmarks.time_box_filter_on_partition
1.87±0.02s 1.88±0.02s 1.01 benchmarks.time_create_midsize_catalog
83.5±2ms 84.7±0.3ms 1.01 benchmarks.time_kdtree_crossmatch
29.1±2ms 29.0±0.4ms 1 benchmarks.time_polygon_search
12.7±0.01s 12.5±0.03s 0.99 benchmarks.time_create_large_catalog

Click here to view all benchmarks.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.38%. Comparing base (965ef8f) to head (45cb801).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #537   +/-   ##
=======================================
  Coverage   97.38%   97.38%           
=======================================
  Files          43       43           
  Lines        1719     1724    +5     
=======================================
+ Hits         1674     1679    +5     
  Misses         45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smcguire-cmu smcguire-cmu merged commit 95df3bd into main Jan 8, 2025
11 checks passed
@smcguire-cmu smcguire-cmu deleted the sean/catalog-overlap-error branch January 8, 2025 18:28
@delucchi-cmu delucchi-cmu mentioned this pull request Jan 24, 2025
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unfriendly failure on non-overlapping catalogs
2 participants