Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Catalog Lazy Representation #514

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Conversation

smcguire-cmu
Copy link
Contributor

  • Changes index column from healpix_29 divisions to healpix pixels
  • Adds warning that catalog is only lazily read

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.40%. Comparing base (35034f1) to head (0f282a9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/lsdb/catalog/dataset/dataset.py 75.00% 1 Missing ⚠️
src/lsdb/catalog/dataset/healpix_dataset.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #514      +/-   ##
==========================================
- Coverage   97.50%   97.40%   -0.10%     
==========================================
  Files          43       43              
  Lines        1681     1697      +16     
==========================================
+ Hits         1639     1653      +14     
- Misses         42       44       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@camposandro camposandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks great! Can we just update the images of the Getting Started docs to show the current representation? the second image is unrelated to this change but it still shows a _hipscat_index column.

Base automatically changed from margin to main November 26, 2024 21:19
@smcguire-cmu smcguire-cmu force-pushed the sean/catalog_lazy_repr branch from 527d187 to 0f282a9 Compare December 3, 2024 18:50
Copy link

github-actions bot commented Dec 3, 2024

Before [35034f1] After [e38f63f] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.time_box_filter_on_partition
failed failed n/a benchmarks.time_polygon_search
102±0.3ms 106±1ms 1.04 benchmarks.time_kdtree_crossmatch
14.6±0.08s 14.5±0.07s 0.99 benchmarks.time_create_large_catalog
2.16±0.02s 2.14±0.04s 0.99 benchmarks.time_create_midsize_catalog

Click here to view all benchmarks.

@smcguire-cmu smcguire-cmu merged commit dd92005 into main Dec 3, 2024
9 of 11 checks passed
@smcguire-cmu smcguire-cmu deleted the sean/catalog_lazy_repr branch December 3, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants