Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address warning on writing catalog. #488

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Address warning on writing catalog. #488

merged 1 commit into from
Nov 1, 2024

Conversation

delucchi-cmu
Copy link
Contributor

Closes #478

I was looking into something unrelated, and observed this and got annoyed.

Copy link
Member

@OliviaLynn OliviaLynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.67%. Comparing base (3041d6d) to head (80237d5).
Report is 66 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #488   +/-   ##
=======================================
  Coverage   97.67%   97.67%           
=======================================
  Files          39       39           
  Lines        1546     1546           
=======================================
  Hits         1510     1510           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 1, 2024

Before [3041d6d] After [ce38e95] Ratio Benchmark (Parameter)
15.8±0.08ms 15.5±0.2ms 0.98 benchmarks.time_box_filter_on_partition
14.4±0.07s 14.2±0.01s 0.98 benchmarks.time_create_large_catalog
2.16±0.01s 2.12±0.01s 0.98 benchmarks.time_create_midsize_catalog
102±1ms 101±2ms 0.98 benchmarks.time_kdtree_crossmatch
29.8±0.5ms 29.4±0.4ms 0.98 benchmarks.time_polygon_search

Click here to view all benchmarks.

@delucchi-cmu delucchi-cmu merged commit f5a3e20 into main Nov 1, 2024
11 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/478/int branch November 1, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UserWarning: Expected int but got int64 with value `np.int64(2)
2 participants