Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add join catalogs notebook #481

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Add join catalogs notebook #481

merged 3 commits into from
Nov 5, 2024

Conversation

camposandro
Copy link
Collaborator

Add a notebook to demonstrate joining Gaia DR3 with Gaia EDR3 distances. Closes #388.

@camposandro camposandro requested a review from hombit October 31, 2024 18:36
@camposandro camposandro self-assigned this Oct 31, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.67%. Comparing base (b7f8127) to head (bf91cc8).
Report is 71 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #481   +/-   ##
=======================================
  Coverage   97.67%   97.67%           
=======================================
  Files          39       39           
  Lines        1546     1546           
=======================================
  Hits         1510     1510           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 31, 2024

Before [b7f8127] <v0.4.1> After [44a93b4] Ratio Benchmark (Parameter)
106±1ms 108±0.9ms 1.02 benchmarks.time_kdtree_crossmatch
31.9±0.4ms 32.4±0.4ms 1.02 benchmarks.time_polygon_search
14.5±0.04s 14.6±0.03s 1.01 benchmarks.time_create_large_catalog
17.7±0.4ms 17.6±0.3ms 0.99 benchmarks.time_box_filter_on_partition
2.16±0.02s 2.15±0.02s 0.99 benchmarks.time_create_midsize_catalog

Click here to view all benchmarks.

@camposandro camposandro merged commit 0bf36bf into main Nov 5, 2024
11 checks passed
@camposandro camposandro deleted the issue/388/add-join-example branch November 5, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: add join example
2 participants