Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch sky map when catalog has empty partitions #474

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

camposandro
Copy link
Collaborator

Patch the sky map routine to handle empty partitions when a histogram order is specified. Closes #450.

@camposandro camposandro self-assigned this Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.66%. Comparing base (c9779aa) to head (7db6aea).
Report is 74 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #474   +/-   ##
=======================================
  Coverage   97.65%   97.66%           
=======================================
  Files          39       39           
  Lines        1537     1541    +4     
=======================================
+ Hits         1501     1505    +4     
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 29, 2024

Before [c9779aa] After [f212908] Ratio Benchmark (Parameter)
2.19±0.01s 2.20±0.03s 1.01 benchmarks.time_create_midsize_catalog
18.1±0.2ms 18.0±0.1ms 1 benchmarks.time_box_filter_on_partition
14.7±0s 14.6±0s 1 benchmarks.time_create_large_catalog
108±0.8ms 106±1ms 0.98 benchmarks.time_kdtree_crossmatch
33.1±0.6ms 32.3±0.6ms 0.98 benchmarks.time_polygon_search

Click here to view all benchmarks.

@camposandro camposandro merged commit 6888b52 into main Oct 29, 2024
11 checks passed
@camposandro camposandro deleted the issue/450/skymap-empty-partitions branch October 29, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plotting a lsdb.skymap fails if the input HATS catalog has empty pixels
2 participants