Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Cluster Authorized IP Management #69

Merged
merged 4 commits into from
Nov 4, 2022
Merged

Improve Cluster Authorized IP Management #69

merged 4 commits into from
Nov 4, 2022

Conversation

mishah334
Copy link
Contributor

@mishah334 mishah334 commented Nov 3, 2022 •
edited
Loading

Improvements

  • Currently one can input only a single IP address to allow access. Now, you can one or many IP addresses to allow access in case of a Public cluster.
  • Removing self-IP management from the module. As you can input multiple IPs, one can input that.

danielhoherd
danielhoherd approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@danielhoherd danielhoherd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mishah334 mishah334 merged commit cc5178a into master Nov 4, 2022
@mishah334 mishah334 deleted the improve-allow-ip-mgmt branch November 4, 2022 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielhoherd danielhoherd danielhoherd approved these changes

@shmanu017 shmanu017 Awaiting requested review from shmanu017

@pgvishnuram pgvishnuram Awaiting requested review from pgvishnuram

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mishah334 @danielhoherd