Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default postgres engine value to 11.9 #57

Merged
merged 4 commits into from
Feb 19, 2021

Conversation

cmarteepants
Copy link
Contributor

As per AWS documentation, 10.7 is no longer supported.
https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/AuroraPostgreSQL.Updates.20180305.html#AuroraPostgreSQL.Updates.20180305.23

TF throws an error when installing Astronomer Platform. 10.7 is also not available via the UI.

As per AWS documentation, 10.7 is no longer supported.
https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/AuroraPostgreSQL.Updates.20180305.html#AuroraPostgreSQL.Updates.20180305.23

TF throws an error when installing Astronomer Platform, and
the old engine version is also not available via the UI.
@cmarteepants cmarteepants added the bug Something isn't working label Feb 19, 2021
@pritt20
Copy link
Contributor

pritt20 commented Feb 19, 2021

Hey @cmarteepants ,

It looks like we'll also need to update DBParameterGroupFamily from aurora-postgresql10 to aurora-postgresql11 and rdsClusterParameterGroupFamily aurora-postgresql10 to aurora-postgresql11.

family = "aurora-postgresql10"

family = "aurora-postgresql10"

CC: @ianstanton

@cmarteepants
Copy link
Contributor Author

cmarteepants commented Feb 19, 2021

Great catch, thanks @pritt20!

Instead of hardcoding it, I chose to infer it based on the engine_version. Less to enter if we need to quickly override the default.

@danielhoherd danielhoherd merged commit 3297e1f into master Feb 19, 2021
@danielhoherd danielhoherd deleted the update-default-aurora-pg-version branch February 19, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants