Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tag value in slack notification #55

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Update tag value in slack notification #55

merged 1 commit into from
Jan 7, 2021

Conversation

ianstanton
Copy link
Contributor

  • Slack notifications for successful tags show the wrong tag 1.2.x
  • Update to proper tag 2.0.x

tommyk
tommyk approved these changes Jan 7, 2021
View reviewed changes
Copy link

@tommyk tommyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems simple enough!

@ianstanton ianstanton merged commit 4ec4a9e into master Jan 7, 2021
@ianstanton ianstanton deleted the update-slack-tag branch January 7, 2021 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielhoherd danielhoherd danielhoherd approved these changes

@tommyk tommyk tommyk approved these changes

@sjmiller609 sjmiller609 Awaiting requested review from sjmiller609

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ianstanton @tommyk @danielhoherd