Fix issue with airflow-2-6-0rc1 #1899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajastro
force-pushed
the
airflow-rc-2-6-0
branch
2 times, most recently
from
6e6cb73 to
fc5920e
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1899 +/- ##
==========================================
- Coverage 86.13% 84.78% -1.35%
==========================================
Files 127 104 -23
Lines 6837 5950 -887
Branches 675 677 +2
==========================================
- Hits 5889 5045 -844
+ Misses 794 761 -33
+ Partials 154 144 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
dimberman
reviewed
Apr 19, 2023
utkarsharma2
changed the title
utkarsharma2
changed the title
pankajastro
requested review from
tatiana,
sunank200 and
pankajkoti
as code owners
pankajastro
commented
Apr 25, 2023
pankajastro
commented
Apr 25, 2023
tatiana
approved these changes
May 3, 2023
There was a problem hiding this comment.
This is a blocker for the 1.6 release, which is expected by customers urgently. For this reason, I'm approving and merging the PR before we meet our desired code coverage (currently, we only have 76.19% of diff hit, while our target for diff coverage is 86.13%).
tatiana
reviewed
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the current behavior?
Tested with Airflow 2.6rc and found there are a couple of issues related
airflow.jobs.scheduler_job.SchedulerJobandairflow.jobs.backfill_job.BackfillJobClasses removed.Closes: #1904
What is the new behavior?
Added fixes for the above issues.
Does this introduce a breaking change?
Nope.
Checklist