Restore Python SDK 1.4 pandas load option classes with deprecation warning #1795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utkarsharma2
requested review from
dimberman,
tatiana,
sunank200,
pankajastro,
pankajkoti and
feluelle
as code owners
Codecov ReportBase: 97.67% // Head: 93.49% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1795 +/- ##
==========================================
- Coverage 97.67% 93.49% -4.18%
==========================================
Files 23 93 +70
Lines 904 4967 +4063
Branches 0 492 +492
==========================================
+ Hits 883 4644 +3761
- Misses 21 232 +211
- Partials 0 91 +91
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tatiana
approved these changes
Feb 23, 2023
There was a problem hiding this comment.
That was really quick, @utkarsharma2 ! Thanks for restoring the classes.
Feel free to merge it once the checks pass.
tatiana
changed the title
tatiana
changed the title
tatiana
changed the title
phanikumv
reviewed
Feb 23, 2023
Co-authored-by: Phani Kumar <94376113+phanikumv@users.noreply.github.com>
utkarsharma2
added a commit
that referenced
this pull request
Feb 23, 2023
…rning (#1795) # Description ## What is the current behavior? Currently, we have removed the pandas load options in minor release `1.5.0` which should only be done in major release `2.0.0` after sufficient deprecation warning in minor releases. ref: https://astronomer.slack.com/archives/C02B8SPT93K/p1677076539940629 ## What is the new behavior? In this PR we reintroduced pandas load options classes with deprecation warnings ## Does this introduce a breaking change? Nope ### Checklist - [ ] Created tests which fail without the change (if possible) - [ ] Extended the README / documentation, if necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the current behavior?
Currently, we have removed the pandas load options in minor release
1.5.0which should only be done in major release2.0.0after sufficient deprecation warning in minor releases.ref: https://astronomer.slack.com/archives/C02B8SPT93K/p1677076539940629
What is the new behavior?
In this PR we reintroduced pandas load options classes with deprecation warnings
Does this introduce a breaking change?
Nope
Checklist