-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix run_raw_sql() operartor #1700
Conversation
Codecov ReportBase: 93.63% // Head: 93.10% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1700 +/- ##
==========================================
- Coverage 93.63% 93.10% -0.53%
==========================================
Files 90 90
Lines 4712 4714 +2
Branches 468 468
==========================================
- Hits 4412 4389 -23
- Misses 213 234 +21
- Partials 87 91 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
2fca4b8
to
709e024
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@utkarsharma2 how does it will behave after this change if I'll pass multiple Dataframe and a non-temp table? Does it will accept a list of output tables??
@pankajastro there is no impact for Example:
Because the data of |
Good catch! 🚀 cc @tatiana: I think this is the PR you had meant yesterday 👍 |
# Description ## What is the current behavior? When we pass multiple dataframes to run_raw_sql() the expected behavior is that the dataframes should be loaded to different temp tables. Currently, that's not happening, and all the data frames are loaded to the same temp table. Later dataframe overrides a former one. closes: #1687 ## What is the new behavior? Every dataframe is loaded to a different temp table. ## Does this introduce a breaking change? Nope ### Checklist - [ ] Created tests which fail without the change (if possible) - [ ] Extended the README / documentation, if necessary
Description
What is the current behavior?
When we pass multiple dataframes to run_raw_sql() the expected behavior is that the dataframes should be loaded to different temp tables. Currently, that's not happening, and all the data frames are loaded to the same temp table. Later dataframe overrides a former one.
closes: #1687
What is the new behavior?
Every dataframe is loaded to a different temp table.
Does this introduce a breaking change?
Nope
Checklist