-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin sphinx-autoapi==2.0.0 version #1609
Conversation
Codecov ReportBase: 97.73% // Head: 93.02% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1609 +/- ##
==========================================
- Coverage 97.73% 93.02% -4.71%
==========================================
Files 22 90 +68
Lines 794 4472 +3678
Branches 0 444 +444
==========================================
+ Hits 776 4160 +3384
- Misses 18 223 +205
- Partials 0 89 +89
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@pankajastro to me this does not sound like an error. It is a warning which we treat as an error - and we should resolve this. |
@feluelle It makes sense to me when there are multiple references to FileType(in constant and file module), but it's raising this issue even when there is only one reference. I think's an issue with Sphinx right? An alternative would be to update the codebase to use |
Okay, can't we be more specific and help sphinx to find the right |
Looks like some issue on sphinx-autoapi side though I have not investigated it thoroughly since we have simple case two class have same name and we are importing one of them. |
yes, we can remove one but after that it fail https://github.com/astronomer/astro-sdk/blob/main/python-sdk/src/astro/databases/base.py#L69 where we have one import |
Even then we are having issues when there is only one import with FileType. I think it's an issue on |
Alright. Let's wait for a fix and revisit next time we come across the comment. |
# Description ## What is the current behavior? build-docs is broken on sphinx-autoapi-2.0.1 ``` Warning, treated as error: /Users/pankaj/Documents/astro_code/astro-sdk/python-sdk/docs/autoapi/astro/databases/base/index.rst:80:more than one target found for cross-reference 'FileType': astro.constants.FileType, astro.files.types.base.FileType make: *** [html] Error 2 ``` ## What is the new behavior? pin sphinx-autoapi to 2.0.0 ## Does this introduce a breaking change? ### Checklist - [ ] Created tests which fail without the change (if possible) - [ ] Extended the README / documentation, if necessary Co-authored-by: Daniel Imberman <daniel.imberman@gmail.com> (cherry picked from commit 2112c6d)
Description
What is the current behavior?
build-docs is broken on sphinx-autoapi-2.0.1
What is the new behavior?
pin sphinx-autoapi to 2.0.0
Does this introduce a breaking change?
Checklist