Add a snowflake load options #1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Codecov ReportBase: 94.00% // Head: 94.03% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1516 +/- ##
==========================================
+ Coverage 94.00% 94.03% +0.03%
==========================================
Files 89 89
Lines 4368 4390 +22
Branches 432 438 +6
==========================================
+ Hits 4106 4128 +22
Misses 178 178
Partials 84 84
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tatiana
reviewed
Jan 5, 2023
dimberman
requested review from
utkarsharma2,
sunank200,
pankajastro,
pankajkoti and
feluelle
as code owners
feluelle
reviewed
Jan 6, 2023
pankajastro
reviewed
Jan 6, 2023
…oad_options/snowflake_load_options
pankajkoti
reviewed
Jan 9, 2023
feluelle
approved these changes
Jan 9, 2023
…oad_options/snowflake_load_options
|
@pankajastro I've created a ticket for wider documentation around LoadOptions. I don't want to hold up the 1.4 release over this so I think it's fine to do a more thorough job here. #1556 |
utkarsharma2
pushed a commit
that referenced
this pull request
Jan 17, 2023
# Description ## What is the current behavior? The current behavior for loading data to Snowflake is to depend on `native_kwargs`, which are loosely defined and lack type safety. There is also no way to specify `FILE_FORMAT` options in Snowflake, which can block users from being able to load their data. ## What is the new behavior? This PR introduces a `SnowflakeLoadOptions` class that contains `file_format_options` and `copy_options` fields. These fields allow users to specify the necessary arguments to correctly load their data. ## Does this introduce a breaking change? No, this does not introduce a breaking change. ### Checklist - [ ] Created tests which fail without the change (if possible) - [ ] Extended the README / documentation, if necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the current behavior?
The current behavior for loading data to Snowflake is to depend on
native_kwargs, which are loosely defined and lack type safety. There is also no way to specifyFILE_FORMAToptions in Snowflake, which can block users from being able to load their data.What is the new behavior?
This PR introduces a
SnowflakeLoadOptionsclass that containsfile_format_optionsandcopy_optionsfields. These fields allow users to specify the necessary arguments to correctly load their data.Does this introduce a breaking change?
No, this does not introduce a breaking change.
Checklist