Get the file location based on path and conn_id #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunank200
requested review from
dimberman,
tatiana,
utkarsharma2,
pankajastro,
pankajkoti and
feluelle
as code owners
pankajastro
reviewed
Dec 21, 2022
|
Also, I think, we can add this quirk to docs as well. |
Codecov ReportBase: 93.65% // Head: 93.67% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1478 +/- ##
==========================================
+ Coverage 93.65% 93.67% +0.02%
==========================================
Files 84 84
Lines 4067 4082 +15
Branches 402 404 +2
==========================================
+ Hits 3809 3824 +15
Misses 177 177
Partials 81 81
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
kaxil
reviewed
Dec 21, 2022
kaxil
reviewed
Dec 21, 2022
kaxil
reviewed
Dec 28, 2022
|
test is failing: |
kaxil
reviewed
Dec 28, 2022
kaxil
reviewed
Dec 28, 2022
kaxil
reviewed
Dec 28, 2022
kaxil
reviewed
Dec 28, 2022
kaxil
reviewed
Dec 28, 2022
kaxil
reviewed
Dec 28, 2022
kaxil
reviewed
Dec 28, 2022
kaxil
reviewed
Dec 28, 2022
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
kaxil
approved these changes
Dec 28, 2022
sunank200
added a commit
that referenced
this pull request
Dec 29, 2022
# Description ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Currently `create_file_location` is picking module path based on `filetype.value` even tough the `conn_id` is passed. https://github.com/astronomer/astro-sdk/blob/main/python-sdk/src/astro/files/locations/__init__.py#L23 get_location_type doesn't take care of fetching the filelocation based on `conn_type` as per `conn_id` at all. It just picks up from the path. <!-- Issues are required for both bug fixes and features. Reference it using one of the following: closes: #ISSUE related: #ISSUE --> closes: #1471 ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Add `validate_conn()` in BaseFilelocation class to match file path and connection type ## Does this introduce a breaking change? No ### Checklist - [x] Created tests which fail without the change (if possible) - [x] Extended the README / documentation, if necessary Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
utkarsharma2
pushed a commit
that referenced
this pull request
Jan 17, 2023
# Description ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Currently `create_file_location` is picking module path based on `filetype.value` even tough the `conn_id` is passed. https://github.com/astronomer/astro-sdk/blob/main/python-sdk/src/astro/files/locations/__init__.py#L23 get_location_type doesn't take care of fetching the filelocation based on `conn_type` as per `conn_id` at all. It just picks up from the path. <!-- Issues are required for both bug fixes and features. Reference it using one of the following: closes: #ISSUE related: #ISSUE --> closes: #1471 ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Add `validate_conn()` in BaseFilelocation class to match file path and connection type ## Does this introduce a breaking change? No ### Checklist - [x] Created tests which fail without the change (if possible) - [x] Extended the README / documentation, if necessary Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the current behavior?
Currently
create_file_locationis picking module path based onfiletype.valueeven tough theconn_idis passed. https://github.com/astronomer/astro-sdk/blob/main/python-sdk/src/astro/files/locations/__init__.py#L23 get_location_type doesn't take care of fetching the filelocation based onconn_typeas perconn_idat all. It just picks up from the path.closes: #1471
What is the new behavior?
validate_conn()in BaseFilelocation class to match file path and connection typeDoes this introduce a breaking change?
No
Checklist