-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate constraints on releases and pushes (not PRs) #1472
Conversation
This will limit generating constraints on releases and pushes (not PRs). I don't think we need to generate constraints on every PR
f5dddc7
to
50257f9
Compare
@@ -364,6 +364,7 @@ jobs: | |||
AZURE_WASB_CONN_STRING: ${{ secrets.AZURE_WASB_CONN_STRING }} | |||
|
|||
Generate-Constraints: | |||
if: (github.event_name == 'release' || github.event_name == 'push') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to check that the push is on main branch?
I see the the action is skipped here but is it that the commit was pushed first and then the pull request was created and hence it got skipped. What if we push a commit to an existing pull request? Will it skip then also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We restrict pushes on main
and release branches only in the following block
astro-sdk/.github/workflows/ci-python-sdk.yaml
Lines 2 to 4 in 50257f9
on: | |
push: | |
branches: [ 'main', 'release-**' ] |
Hence it won't send push event for other branches to this job
Codecov ReportBase: 92.90% // Head: 97.32% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1472 +/- ##
==========================================
+ Coverage 92.90% 97.32% +4.41%
==========================================
Files 61 19 -42
Lines 3215 672 -2543
Branches 382 0 -382
==========================================
- Hits 2987 654 -2333
+ Misses 151 18 -133
+ Partials 77 0 -77 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Failures are unrelated, merging |
This will limit generating constraints on releases and pushes (not PRs). I don't think we need to generate constraints on every PR