Alternate approach to get location for Bigquery tables #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
commented
Dec 16, 2022
kaxil
commented
Dec 16, 2022
Codecov ReportBase: 97.32% // Head: 97.32% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1449 +/- ##
=======================================
Coverage 97.32% 97.32%
=======================================
Files 19 19
Lines 672 672
=======================================
Hits 654 654
Misses 18 18 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
kaxil
force-pushed
the
hack-schema-location
branch
3 times, most recently
from
58a75cb to
95adc25
Compare
kaxil
commented
Dec 17, 2022
kaxil
force-pushed
the
hack-schema-location
branch
from
95adc25 to
77039fe
Compare
kaxil
commented
Dec 18, 2022
kaxil
force-pushed
the
hack-schema-location
branch
from
085bd70 to
bf9734f
Compare
kaxil
force-pushed
the
hack-schema-location
branch
from
bf9734f to
4358476
Compare
utkarsharma2
approved these changes
Dec 19, 2022
dimberman
previously requested changes
Dec 19, 2022
`numpy.int` was initially deprecated and now removed in 1.24 released yday ```python In [3]: numpy.int <ipython-input-3-1989d03c08d8>:1: DeprecationWarning: `np.int` is a deprecated alias for the builtin `int`. To silence this warning, use `int` by itself. Doing this will not modify any behavior and is safe. When replacing `np.int`, you may wish to use e.g. `np.int64` or `np.int32` to specify the precision. If you wish to review your current use, check the release note link for additional information. Deprecated in NumPy 1.20; for more details and guidance: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations numpy.int Out[3]: int ``` This (cherry picked from commit 745ab5f)
kaxil
requested review from
tatiana,
sunank200,
pankajastro,
pankajkoti and
feluelle
as code owners
kaxil
dismissed
dimberman’s stale review
Addressed comments & Cloud IDE team is waiting for this release
kaxil
added a commit
that referenced
this pull request
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternate approach to #1416
Also closes #1460
ToDo:
The
regionparameter passed to Table wasn't used anywhere except internally -- so going to remove it without deprecation