Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SN classification based on Random Forest #319

Merged
merged 6 commits into from
Jan 7, 2020

Conversation

JulienPeloton
Copy link
Member

@JulienPeloton JulienPeloton commented Jan 7, 2020

IMPORTANT: Please create an issue first before opening a Pull Request.
Linked to issue(s): #318

What changes were proposed in this pull request?

This PR adds a new processor rfscore to compute the probability of an alert to be a SN Ia. The classification is based on the Machine Learning Random Forest algorithm. See #318 and astrolabsoftware/fink-science#15 for the implementation. To work, this new feature requires fink-science>=0.1.8 installed.

Note that the introduction of a new science module gives rise to a new schema for alert distribution (a new field is added). After the merging, the distribution schema will be schemas/distribution_schema_0p2.avsc.

Minor:

  • Add two new dependencies in the requirements: scipy and scikit-learn
  • Fix numpy version in the requirements.txt to satisfy Scipy requirements.

How was this patch tested?

Manually and CI

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #319 into master will increase coverage by <1%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #319    +/-   ##
======================================
+ Coverage      93%    93%   +<1%     
======================================
  Files          16     16            
  Lines         745    756    +11     
======================================
+ Hits          694    705    +11     
  Misses         51     51
Impacted Files Coverage Δ
bin/raw2science.py 97% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4be67ec...bc8adc7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant