Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove gossipnet from relayer #333

Closed
Tracked by #325
joroshiba opened this issue Sep 6, 2023 · 0 comments · Fixed by #384
Closed
Tracked by #325

remove gossipnet from relayer #333

joroshiba opened this issue Sep 6, 2023 · 0 comments · Fixed by #384
Assignees
@SuperFluffy
Labels
gossipnet pertaining to the astria-gossipnet crate sequencer-relayer pertaining to the astria-sequencer-relayer crate

Comments

@joroshiba
Copy link
Member

joroshiba commented Sep 6, 2023 •
edited by sync-by-unito bot
Loading

Based on discussion in #325, where we have opted for option 1.

We no longer need to push blocks to gossipnet, should remove setup, configuration, and push to gossipnet from the workflow.
@joroshiba joroshiba mentioned this issue Sep 6, 2023
Closed
@joroshiba joroshiba added gossipnet pertaining to the astria-gossipnet crate sequencer-relayer pertaining to the astria-sequencer-relayer crate labels Sep 6, 2023
@joroshiba joroshiba mentioned this issue Sep 6, 2023
Closed
@SuperFluffy SuperFluffy mentioned this issue Sep 13, 2023
Closed
This was referenced Sep 14, 2023
Closed
Merged
@emhane emhane assigned SuperFluffy and unassigned emhane Sep 18, 2023
This was referenced Sep 19, 2023
Closed
Closed
SuperFluffy added a commit that referenced this issue Sep 20, 2023
@SuperFluffy
sequencer-relayer: remove gossipnet (#384)
a928e24 
## Summary
Remove all gossipnet functionality from sequencer-relayer. This changes
sequencer-relayer from optionally writing to the data availability layer
to always writing to the DA.

## Background
Adding p2p to astria services adds a low of complexity.
#325 contains background
information on why it was decided to remove it.

## Changes
- Remove functionality to gossip new sequencer blocks over p2p
- Remove toggle to submit blocks to celestia: this is now the main (and
only) functionality of sequencer-relayer
- Update all tests because the removal of gossipnet significantly
changes test choreography.

## Testing
Blackbox test were updated and are passing.

## Breaking Changelist
- This is a breaking change primarily for astria-conductor, which can no
longer expect to receive blocks over p2p.
- All env vars related to p2p no longer matter
- sequencer relayer now must have a valid celestia bearer token and url
to the celestia node rpc

## Related Issues
closes #333
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SuperFluffy SuperFluffy

Labels
gossipnet pertaining to the astria-gossipnet crate sequencer-relayer pertaining to the astria-sequencer-relayer crate
Projects
None yet
Milestone
No milestone
3 participants
@joroshiba @SuperFluffy @emhane