link-ipps depends on link-ippvm #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Published in ipp-sys 0.4.5. Does this work for you? |
|
Works now. Thank you. |
|
Great, also all my tests are still passing on Linux, Mac and Windows from IPP 2017 to 2019. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like link-ipps needs to depend on link-ippvm to statically build on Linux
In my last PR I was testing by manually linking in just the link-libvm instead of through ipps-sys. I'm not sure if there are other cross lib dependencies. But for what I was doing it was missing y8_ippsSin_32f_A24 (and a few similarly named functions), which are only referenced in libipps.a and libippvm.a