Audit/oracle/non zero check for ids

[JordyRo1]

No description provided.

[github-actions]

Output from Compare Snapshot:

****IMPROVEMENTS****
None


****WORSENED****
pragma::tests::test_oracle::get_data_for_sources 25940336 --> 25955836 0.06 %
pragma::tests::test_oracle::get_data_median 36090886 --> 36106386 0.04 %
pragma::tests::test_oracle::get_data_median_for_sources 23017256 --> 23032756 0.07 %
pragma::tests::test_oracle::get_data_median_for_sources_should_fail_if_wrong_sources 20970376 --> 20985876 0.07 %
pragma::tests::test_oracle::test_add_currency_should_fail_if_currency_id_null 20451206 --> 20466706 0.08 %
pragma::tests::test_oracle::test_add_pair_should_panic_if_base_currency_do_not_corresponds 20596176 --> 20612376 0.08 %
pragma::tests::test_oracle::test_add_pair_should_panic_if_quote_currency_do_not_corresponds 20621176 --> 20637376 0.08 %
pragma::tests::test_oracle::test_data_entry 22603676 --> 22619176 0.07 %
pragma::tests::test_oracle::test_data_entry_should_fail_if_not_found 20336276 --> 20351776 0.08 %
pragma::tests::test_oracle::test_data_entry_should_fail_if_not_found_2 20336276 --> 20351776 0.08 %
pragma::tests::test_oracle::test_data_entry_should_fail_if_not_found_3 20336276 --> 20351776 0.08 %
pragma::tests::test_oracle::test_data_median_multi_should_fail_if_no_expiration_time_associated 20947576 --> 20963076 0.07 %
pragma::tests::test_oracle::test_data_median_multi_should_fail_if_wrong_data_types 21697936 --> 21713436 0.07 %
pragma::tests::test_oracle::test_data_median_multi_should_fail_if_wrong_sources 21716346 --> 21731846 0.07 %
pragma::tests::test_oracle::test_get_admin_address 20220596 --> 20236096 0.08 %
pragma::tests::test_oracle::test_get_all_publishers 23274928 --> 23290428 0.07 %
pragma::tests::test_oracle::test_get_all_sources 20750906 --> 20766406 0.07 %
pragma::tests::test_oracle::test_get_data 43003396 --> 43018896 0.04 %
pragma::tests::test_oracle::test_get_data_entry_for_publishers 33513534 --> 33529034 0.05 %
pragma::tests::test_oracle::test_get_data_median_multi 32502326 --> 32517826 0.05 %
pragma::tests::test_oracle::test_get_data_with_USD_hop_should_fail_if_wrong_id 21548356 --> 21563856 0.07 %
pragma::tests::test_oracle::test_get_data_with_usd_hop 32021036 --> 32036536 0.05 %
pragma::tests::test_oracle::test_get_data_with_usd_hop_diff 24851676 --> 24867176 0.06 %
pragma::tests::test_oracle::test_get_decimals 21202606 --> 21218106 0.07 %
pragma::tests::test_oracle::test_get_decimals_should_fail_if_not_found 20359696 --> 20375196 0.08 %
pragma::tests::test_oracle::test_get_decimals_should_fail_if_not_found_2 20359696 --> 20375196 0.08 %
pragma::tests::test_oracle::test_get_last_checkpoint_before 28010756 --> 28026256 0.06 %
pragma::tests::test_oracle::test_get_last_checkpoint_before_should_fail_if_timestamp_too_old 27526086 --> 27541586 0.06 %
pragma::tests::test_oracle::test_get_last_checkpoint_before_should_fail_if_wrong_data_type 27526086 --> 27541586 0.06 %
pragma::tests::test_oracle::test_max_publish_multiple_entries 54673988 --> 54689488 0.03 %
pragma::tests::test_oracle::test_multiple_publishers_price 68216790 --> 68232290 0.02 %
pragma::tests::test_oracle::test_publish_multiple_entries 31796940 --> 31812440 0.05 %
pragma::tests::test_oracle::test_set_checkpoint 27834576 --> 27850076 0.06 %
pragma::tests::test_oracle::test_set_checkpoint_should_fail_if_wrong_data_type 20994316 --> 21009816 0.07 %
pragma::tests::test_oracle::test_transfer_ownership 20590696 --> 20606196 0.08 %
pragma::tests::test_summary_stats::test_set_future_checkpoint 66054838 --> 66065738 0.02 %
pragma::tests::test_summary_stats::test_summary_stats_mean_mean 62576632 --> 62586432 0.02 %
pragma::tests::test_summary_stats::test_summary_stats_mean_median 62576632 --> 62586432 0.02 %
pragma::tests::test_yield_curve::test_yield_curve_computation 21511582 --> 21520082 0.04 %
pragma::tests::test_yield_curve::test_yield_curve_deploy 5418460 --> 5426960 0.16 %
pragma::tests::test_yield_curve::test_yield_curve_empty 6187160 --> 6195660 0.14 %


Overall gas change: performance degradation, gas consumption +0.05 %

[github-actions]

Output from Compare Snapshot:

****IMPROVEMENTS****
None


****WORSENED****
pragma::tests::test_oracle::get_data_for_sources 27403136 --> 27417936 0.05 %
pragma::tests::test_oracle::get_data_median 37560686 --> 37575486 0.04 %
pragma::tests::test_oracle::get_data_median_for_sources 24477556 --> 24492356 0.06 %
pragma::tests::test_oracle::get_data_median_for_sources_should_fail_if_wrong_sources 22428176 --> 22442976 0.07 %
pragma::tests::test_oracle::test_add_currency_should_fail_if_currency_id_null 21909006 --> 21923806 0.07 %
pragma::tests::test_oracle::test_add_pair_should_panic_if_base_currency_do_not_corresponds 22053976 --> 22069476 0.07 %
pragma::tests::test_oracle::test_add_pair_should_panic_if_quote_currency_do_not_corresponds 22078976 --> 22094476 0.07 %
pragma::tests::test_oracle::test_data_entry 24061476 --> 24076276 0.06 %
pragma::tests::test_oracle::test_data_entry_should_fail_if_not_found 21794076 --> 21808876 0.07 %
pragma::tests::test_oracle::test_data_entry_should_fail_if_not_found_2 21794076 --> 21808876 0.07 %
pragma::tests::test_oracle::test_data_entry_should_fail_if_not_found_3 21794076 --> 21808876 0.07 %
pragma::tests::test_oracle::test_data_median_multi_should_fail_if_no_expiration_time_associated 22405376 --> 22420176 0.07 %
pragma::tests::test_oracle::test_data_median_multi_should_fail_if_wrong_data_types 23155736 --> 23170536 0.06 %
pragma::tests::test_oracle::test_data_median_multi_should_fail_if_wrong_sources 23174146 --> 23188946 0.06 %
pragma::tests::test_oracle::test_get_admin_address 21678396 --> 21693196 0.07 %
pragma::tests::test_oracle::test_get_all_publishers 24733428 --> 24748228 0.06 %
pragma::tests::test_oracle::test_get_all_sources 22208706 --> 22223506 0.07 %
pragma::tests::test_oracle::test_get_data 44477696 --> 44492496 0.03 %
pragma::tests::test_oracle::test_get_data_entry_for_publishers 34980734 --> 34995534 0.04 %
pragma::tests::test_oracle::test_get_data_median_multi 33970126 --> 33984926 0.04 %
pragma::tests::test_oracle::test_get_data_with_USD_hop_should_fail_if_wrong_id 23006156 --> 23020956 0.06 %
pragma::tests::test_oracle::test_get_data_with_usd_hop 33485836 --> 33500636 0.04 %
pragma::tests::test_oracle::test_get_data_with_usd_hop_diff 26311476 --> 26326276 0.06 %
pragma::tests::test_oracle::test_get_decimals 22660406 --> 22675206 0.07 %
pragma::tests::test_oracle::test_get_decimals_should_fail_if_not_found 21817496 --> 21832296 0.07 %
pragma::tests::test_oracle::test_get_decimals_should_fail_if_not_found_2 21817496 --> 21832296 0.07 %
pragma::tests::test_oracle::test_get_last_checkpoint_before 29473556 --> 29488356 0.05 %
pragma::tests::test_oracle::test_get_last_checkpoint_before_should_fail_if_timestamp_too_old 28988886 --> 29003686 0.05 %
pragma::tests::test_oracle::test_get_last_checkpoint_before_should_fail_if_wrong_data_type 28988886 --> 29003686 0.05 %
pragma::tests::test_oracle::test_max_publish_multiple_entries 56131788 --> 56146588 0.03 %
pragma::tests::test_oracle::test_multiple_publishers_price 69705790 --> 69720590 0.02 %
pragma::tests::test_oracle::test_publish_multiple_entries 33254740 --> 33269540 0.04 %
pragma::tests::test_oracle::test_set_checkpoint 29297376 --> 29312176 0.05 %
pragma::tests::test_oracle::test_set_checkpoint_should_fail_if_wrong_data_type 22452116 --> 22466916 0.07 %
pragma::tests::test_oracle::test_transfer_ownership 22048496 --> 22063296 0.07 %
pragma::tests::test_summary_stats::test_set_future_checkpoint 66886738 --> 66897238 0.02 %
pragma::tests::test_summary_stats::test_summary_stats_mean_mean 63139652 --> 63149152 0.02 %
pragma::tests::test_summary_stats::test_summary_stats_mean_median 63139652 --> 63149152 0.02 %
pragma::tests::test_yield_curve::test_yield_curve_computation 22111682 --> 22119882 0.04 %
pragma::tests::test_yield_curve::test_yield_curve_deploy 6015060 --> 6023260 0.14 %
pragma::tests::test_yield_curve::test_yield_curve_empty 6783760 --> 6791960 0.12 %


Overall gas change: performance degradation, gas consumption +0.05 %