Feat/transfer ownership #61

JordyRo1 · 2023-11-07T21:50:37Z

No description provided.

…Labs/pragma-oracle into feat/transfer-ownership

github-actions · 2023-11-09T08:31:20Z

Output from Compare Snapshot:

****IMPROVEMENTS****
pragma::tests::test_yield_curve::test_yield_curve_computation 21591422 --> 21511582 -0.37 %
pragma::tests::test_yield_curve::test_yield_curve_deploy 5498300 --> 5418460 -1.45 %
pragma::tests::test_yield_curve::test_yield_curve_empty 6267000 --> 6187160 -1.27 %


****WORSENED****
pragma::tests::test_oracle::get_data_for_sources 25938136 --> 25940336 0.01 %
pragma::tests::test_oracle::get_data_median 36088686 --> 36090886 0.01 %
pragma::tests::test_oracle::get_data_median_for_sources 23015056 --> 23017256 0.01 %
pragma::tests::test_oracle::get_data_median_for_sources_should_fail_if_wrong_sources 20968176 --> 20970376 0.01 %
pragma::tests::test_oracle::test_add_currency_should_fail_if_currency_id_null 20449006 --> 20451206 0.01 %
pragma::tests::test_oracle::test_add_pair_should_panic_if_base_currency_do_not_corresponds 20593976 --> 20596176 0.01 %
pragma::tests::test_oracle::test_add_pair_should_panic_if_quote_currency_do_not_corresponds 20618976 --> 20621176 0.01 %
pragma::tests::test_oracle::test_data_entry 22601476 --> 22603676 0.01 %
pragma::tests::test_oracle::test_data_entry_should_fail_if_not_found 20334076 --> 20336276 0.01 %
pragma::tests::test_oracle::test_data_entry_should_fail_if_not_found_2 20334076 --> 20336276 0.01 %
pragma::tests::test_oracle::test_data_entry_should_fail_if_not_found_3 20334076 --> 20336276 0.01 %
pragma::tests::test_oracle::test_data_median_multi_should_fail_if_no_expiration_time_associated 20945376 --> 20947576 0.01 %
pragma::tests::test_oracle::test_data_median_multi_should_fail_if_wrong_data_types 21695736 --> 21697936 0.01 %
pragma::tests::test_oracle::test_data_median_multi_should_fail_if_wrong_sources 21714146 --> 21716346 0.01 %
pragma::tests::test_oracle::test_get_admin_address 20218396 --> 20220596 0.01 %
pragma::tests::test_oracle::test_get_all_publishers 23272728 --> 23274928 0.01 %
pragma::tests::test_oracle::test_get_all_sources 20748706 --> 20750906 0.01 %
pragma::tests::test_oracle::test_get_data 43001196 --> 43003396 0.01 %
pragma::tests::test_oracle::test_get_data_entry_for_publishers 33511334 --> 33513534 0.01 %
pragma::tests::test_oracle::test_get_data_median_multi 32500126 --> 32502326 0.01 %
pragma::tests::test_oracle::test_get_data_with_USD_hop_should_fail_if_wrong_id 21546156 --> 21548356 0.01 %
pragma::tests::test_oracle::test_get_data_with_usd_hop 32018836 --> 32021036 0.01 %
pragma::tests::test_oracle::test_get_data_with_usd_hop_diff 24849476 --> 24851676 0.01 %
pragma::tests::test_oracle::test_get_decimals 21200406 --> 21202606 0.01 %
pragma::tests::test_oracle::test_get_decimals_should_fail_if_not_found 20357496 --> 20359696 0.01 %
pragma::tests::test_oracle::test_get_decimals_should_fail_if_not_found_2 20357496 --> 20359696 0.01 %
pragma::tests::test_oracle::test_get_last_checkpoint_before 28008556 --> 28010756 0.01 %
pragma::tests::test_oracle::test_get_last_checkpoint_before_should_fail_if_timestamp_too_old 27523886 --> 27526086 0.01 %
pragma::tests::test_oracle::test_get_last_checkpoint_before_should_fail_if_wrong_data_type 27523886 --> 27526086 0.01 %
pragma::tests::test_oracle::test_max_publish_multiple_entries 54671788 --> 54673988 0.00 %
pragma::tests::test_oracle::test_multiple_publishers_price 68214590 --> 68216790 0.00 %
pragma::tests::test_oracle::test_publish_multiple_entries 31794740 --> 31796940 0.01 %
pragma::tests::test_oracle::test_set_checkpoint 27832376 --> 27834576 0.01 %
pragma::tests::test_oracle::test_set_checkpoint_should_fail_if_wrong_data_type 20992116 --> 20994316 0.01 %
pragma::tests::test_publisher_registry::test_add_publisher 1453900 --> 1455000 0.08 %
pragma::tests::test_publisher_registry::test_add_publisher_should_fail_if_not_admin 1310990 --> 1312090 0.08 %
pragma::tests::test_publisher_registry::test_add_publisher_should_fail_if_publisher_already_exists 1315990 --> 1317090 0.08 %
pragma::tests::test_publisher_registry::test_add_source 1763200 --> 1764300 0.06 %
pragma::tests::test_publisher_registry::test_add_source_should_fail_if_not_admin 1317540 --> 1318640 0.08 %
pragma::tests::test_publisher_registry::test_add_source_should_fail_if_source_already_exists 1444880 --> 1445980 0.08 %
pragma::tests::test_publisher_registry::test_change_admin 1377880 --> 1425000 3.42 %
pragma::tests::test_publisher_registry::test_change_admin_should_fail_if_admin_is_same_as_current_admin 1259010 --> 1300130 3.27 %
pragma::tests::test_publisher_registry::test_change_admin_should_fail_if_admin_is_same_as_current_admin_2 1461520 --> 1548660 5.96 %
pragma::tests::test_publisher_registry::test_change_admin_should_fail_if_admin_is_zero 1260930 --> 1302050 3.26 %
pragma::tests::test_publisher_registry::test_change_admin_should_fail_if_not_admin 1254010 --> 1295130 3.28 %
pragma::tests::test_publisher_registry::test_register_non_admin_fail 1310990 --> 1312090 0.08 %
pragma::tests::test_publisher_registry::test_remove_publisher 1556820 --> 1557920 0.07 %
pragma::tests::test_publisher_registry::test_remove_publisher_should_fail_if_not_admin 1402990 --> 1404090 0.08 %
pragma::tests::test_publisher_registry::test_remove_publisher_should_fail_if_publisher_does_not_exist 1407990 --> 1409090 0.08 %
pragma::tests::test_publisher_registry::test_remove_source 1670640 --> 1671740 0.07 %
pragma::tests::test_publisher_registry::test_remove_source_should_fail_if_not_admin 1324620 --> 1325720 0.08 %
pragma::tests::test_publisher_registry::test_remove_source_should_fail_if_source_does_not_exist 1459380 --> 1460480 0.08 %
pragma::tests::test_publisher_registry::test_update_publisher_address 1362060 --> 1363160 0.08 %
pragma::tests::test_publisher_registry::test_update_publisher_should_fail_if_not_publisher 1239150 --> 1240250 0.09 %
pragma::tests::test_randomness::test_randomness 1603010 --> 1604110 0.07 %
pragma::tests::test_summary_stats::test_set_future_checkpoint 66052638 --> 66054838 0.00 %
pragma::tests::test_summary_stats::test_summary_stats_mean_mean 62574432 --> 62576632 0.00 %
pragma::tests::test_summary_stats::test_summary_stats_mean_median 62574432 --> 62576632 0.00 %


Overall gas change: performance degradation, gas consumption +1.75 %

src/tests/test_oracle.cairo

github-actions · 2023-11-09T15:58:36Z

Output from Compare Snapshot:

****IMPROVEMENTS****
pragma::tests::test_yield_curve::test_yield_curve_computation 21591422 --> 21511582 -0.37 %
pragma::tests::test_yield_curve::test_yield_curve_deploy 5498300 --> 5418460 -1.45 %
pragma::tests::test_yield_curve::test_yield_curve_empty 6267000 --> 6187160 -1.27 %


****WORSENED****
pragma::tests::test_oracle::get_data_for_sources 25938136 --> 25940336 0.01 %
pragma::tests::test_oracle::get_data_median 36088686 --> 36090886 0.01 %
pragma::tests::test_oracle::get_data_median_for_sources 23015056 --> 23017256 0.01 %
pragma::tests::test_oracle::get_data_median_for_sources_should_fail_if_wrong_sources 20968176 --> 20970376 0.01 %
pragma::tests::test_oracle::test_add_currency_should_fail_if_currency_id_null 20449006 --> 20451206 0.01 %
pragma::tests::test_oracle::test_add_pair_should_panic_if_base_currency_do_not_corresponds 20593976 --> 20596176 0.01 %
pragma::tests::test_oracle::test_add_pair_should_panic_if_quote_currency_do_not_corresponds 20618976 --> 20621176 0.01 %
pragma::tests::test_oracle::test_data_entry 22601476 --> 22603676 0.01 %
pragma::tests::test_oracle::test_data_entry_should_fail_if_not_found 20334076 --> 20336276 0.01 %
pragma::tests::test_oracle::test_data_entry_should_fail_if_not_found_2 20334076 --> 20336276 0.01 %
pragma::tests::test_oracle::test_data_entry_should_fail_if_not_found_3 20334076 --> 20336276 0.01 %
pragma::tests::test_oracle::test_data_median_multi_should_fail_if_no_expiration_time_associated 20945376 --> 20947576 0.01 %
pragma::tests::test_oracle::test_data_median_multi_should_fail_if_wrong_data_types 21695736 --> 21697936 0.01 %
pragma::tests::test_oracle::test_data_median_multi_should_fail_if_wrong_sources 21714146 --> 21716346 0.01 %
pragma::tests::test_oracle::test_get_admin_address 20218396 --> 20220596 0.01 %
pragma::tests::test_oracle::test_get_all_publishers 23272728 --> 23274928 0.01 %
pragma::tests::test_oracle::test_get_all_sources 20748706 --> 20750906 0.01 %
pragma::tests::test_oracle::test_get_data 43001196 --> 43003396 0.01 %
pragma::tests::test_oracle::test_get_data_entry_for_publishers 33511334 --> 33513534 0.01 %
pragma::tests::test_oracle::test_get_data_median_multi 32500126 --> 32502326 0.01 %
pragma::tests::test_oracle::test_get_data_with_USD_hop_should_fail_if_wrong_id 21546156 --> 21548356 0.01 %
pragma::tests::test_oracle::test_get_data_with_usd_hop 32018836 --> 32021036 0.01 %
pragma::tests::test_oracle::test_get_data_with_usd_hop_diff 24849476 --> 24851676 0.01 %
pragma::tests::test_oracle::test_get_decimals 21200406 --> 21202606 0.01 %
pragma::tests::test_oracle::test_get_decimals_should_fail_if_not_found 20357496 --> 20359696 0.01 %
pragma::tests::test_oracle::test_get_decimals_should_fail_if_not_found_2 20357496 --> 20359696 0.01 %
pragma::tests::test_oracle::test_get_last_checkpoint_before 28008556 --> 28010756 0.01 %
pragma::tests::test_oracle::test_get_last_checkpoint_before_should_fail_if_timestamp_too_old 27523886 --> 27526086 0.01 %
pragma::tests::test_oracle::test_get_last_checkpoint_before_should_fail_if_wrong_data_type 27523886 --> 27526086 0.01 %
pragma::tests::test_oracle::test_max_publish_multiple_entries 54671788 --> 54673988 0.00 %
pragma::tests::test_oracle::test_multiple_publishers_price 68214590 --> 68216790 0.00 %
pragma::tests::test_oracle::test_publish_multiple_entries 31794740 --> 31796940 0.01 %
pragma::tests::test_oracle::test_set_checkpoint 27832376 --> 27834576 0.01 %
pragma::tests::test_oracle::test_set_checkpoint_should_fail_if_wrong_data_type 20992116 --> 20994316 0.01 %
pragma::tests::test_publisher_registry::test_add_publisher 1453900 --> 1455000 0.08 %
pragma::tests::test_publisher_registry::test_add_publisher_should_fail_if_not_admin 1310990 --> 1312090 0.08 %
pragma::tests::test_publisher_registry::test_add_publisher_should_fail_if_publisher_already_exists 1315990 --> 1317090 0.08 %
pragma::tests::test_publisher_registry::test_add_source 1763200 --> 1764300 0.06 %
pragma::tests::test_publisher_registry::test_add_source_should_fail_if_not_admin 1317540 --> 1318640 0.08 %
pragma::tests::test_publisher_registry::test_add_source_should_fail_if_source_already_exists 1444880 --> 1445980 0.08 %
pragma::tests::test_publisher_registry::test_change_admin 1377880 --> 1425000 3.42 %
pragma::tests::test_publisher_registry::test_change_admin_should_fail_if_admin_is_same_as_current_admin 1259010 --> 1300130 3.27 %
pragma::tests::test_publisher_registry::test_change_admin_should_fail_if_admin_is_same_as_current_admin_2 1461520 --> 1548660 5.96 %
pragma::tests::test_publisher_registry::test_change_admin_should_fail_if_admin_is_zero 1260930 --> 1302050 3.26 %
pragma::tests::test_publisher_registry::test_change_admin_should_fail_if_not_admin 1254010 --> 1295130 3.28 %
pragma::tests::test_publisher_registry::test_register_non_admin_fail 1310990 --> 1312090 0.08 %
pragma::tests::test_publisher_registry::test_remove_publisher 1556820 --> 1557920 0.07 %
pragma::tests::test_publisher_registry::test_remove_publisher_should_fail_if_not_admin 1402990 --> 1404090 0.08 %
pragma::tests::test_publisher_registry::test_remove_publisher_should_fail_if_publisher_does_not_exist 1407990 --> 1409090 0.08 %
pragma::tests::test_publisher_registry::test_remove_source 1670640 --> 1671740 0.07 %
pragma::tests::test_publisher_registry::test_remove_source_should_fail_if_not_admin 1324620 --> 1325720 0.08 %
pragma::tests::test_publisher_registry::test_remove_source_should_fail_if_source_does_not_exist 1459380 --> 1460480 0.08 %
pragma::tests::test_publisher_registry::test_update_publisher_address 1362060 --> 1363160 0.08 %
pragma::tests::test_publisher_registry::test_update_publisher_should_fail_if_not_publisher 1239150 --> 1240250 0.09 %
pragma::tests::test_randomness::test_randomness 1603010 --> 1604110 0.07 %
pragma::tests::test_summary_stats::test_set_future_checkpoint 66052638 --> 66054838 0.00 %
pragma::tests::test_summary_stats::test_summary_stats_mean_mean 62574432 --> 62576632 0.00 %
pragma::tests::test_summary_stats::test_summary_stats_mean_median 62574432 --> 62576632 0.00 %


Overall gas change: performance degradation, gas consumption +1.88 %

JordyRo1 and others added 4 commits November 7, 2023 19:57

feat: transfer

f6f103c

feat: tests

f244517

fix: fmt

eb0efed

Merge branch 'main' into feat/transfer-ownership

1b16c28

JordyRo1 mentioned this pull request Nov 7, 2023

Events not emitted under new Ownable implementation #62

Closed

JordyRo1 added 4 commits November 7, 2023 23:05

fix: openzeppelin version

bbcbde5

Merge branch 'feat/transfer-ownership' of https://github.com/Astraly-…

aba8398

…Labs/pragma-oracle into feat/transfer-ownership

fix: commit

00286ad

fix: event management

4998be5

JordyRo1 marked this pull request as ready for review November 9, 2023 08:35

EvolveArt approved these changes Nov 9, 2023

View reviewed changes

src/tests/test_oracle.cairo Show resolved Hide resolved

fix: publisher registry test

8584b31

EvolveArt merged commit 6370090 into main Nov 9, 2023
6 checks passed

EvolveArt deleted the feat/transfer-ownership branch November 9, 2023 16:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/transfer ownership #61

Feat/transfer ownership #61

JordyRo1 commented Nov 7, 2023

github-actions bot commented Nov 9, 2023

github-actions bot commented Nov 9, 2023

Feat/transfer ownership #61

Feat/transfer ownership #61

Conversation

JordyRo1 commented Nov 7, 2023

github-actions bot commented Nov 9, 2023

github-actions bot commented Nov 9, 2023