Remove serde::Serialize implementations for rkyv-able structs
#7663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
the
internal
charliermarsh
commented
Sep 24, 2024
| @@ -346,7 +350,8 @@ impl<'de> serde::de::Deserialize<'de> for ToolUvSources { | |||
| } | |||
| } | |||
|
|
|||
| #[derive(Serialize, Deserialize, OptionsMetadata, Default, Debug, Clone, PartialEq, Eq)] | |||
| #[derive(Deserialize, OptionsMetadata, Default, Debug, Clone, PartialEq, Eq)] | |||
| #[cfg_attr(test, derive(Serialize))] | |||
There was a problem hiding this comment.
Sigh, these need Serialize for testing. Wonder if we should just use the debug repr though.
There was a problem hiding this comment.
Debug repr for tests seems fine to me.
There was a problem hiding this comment.
It's kind of bad because we have glob patterns and the debug repr is very verbose.
BurntSushi
approved these changes
Sep 24, 2024
| @@ -346,7 +350,8 @@ impl<'de> serde::de::Deserialize<'de> for ToolUvSources { | |||
| } | |||
| } | |||
|
|
|||
| #[derive(Serialize, Deserialize, OptionsMetadata, Default, Debug, Clone, PartialEq, Eq)] | |||
| #[derive(Deserialize, OptionsMetadata, Default, Debug, Clone, PartialEq, Eq)] | |||
| #[cfg_attr(test, derive(Serialize))] | |||
There was a problem hiding this comment.
Debug repr for tests seems fine to me.
charliermarsh
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Random, but I noticed that we can remove a ton of serialize and deserialize derives by using
rkyvfor the flat-index caches. (We already userkyvfor these same structs in the registry cache.)