-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the interface for declaring Python download preferences #5936
Conversation
Notably I did not deprecate the |
f808538
to
cb9e39e
Compare
I'm a little uncertain of the "never" value, but I do think it has some utility to require explicit opt-in from the CLI to install versions. |
810f94f
to
f27202b
Compare
f27202b
to
8da8b0d
Compare
Whoops I checked in my |
Thanks. Am I right that I'm wondering it it should be |
I leaned away from |
Yes, only a boolean option is available from the command line and the "manual" value is only accessible via the configuration file. I find that a little peculiar, but don't think it'll be problematic in practice. |
The loose consensus is that "fetch" doesn't have much meaning and that a boolean flag makes more sense from the command line. 1. Adds `--allow-python-downloads` (hidden, default) and `--no-python-downloads` to the CLI to quickly enable or disable downloads 2. Deprecates `--python-fetch` in favor of the options from (1) 3. Removes `python-fetch` in favor of a `python-downloads` setting 5. Adds a `never` variant to the enum, allowing even explicit installs to be disabled via the configuration file I tested this with various `pyproject.toml`-level settings and `uv venv --preview --python 3.12.2` and `uv python install 3.12.2` with and without the new CLI flags.
The loose consensus is that "fetch" doesn't have much meaning and that a boolean flag makes more sense from the command line.
--allow-python-downloads
(hidden, default) and--no-python-downloads
to the CLI to quickly enable or disable downloads--python-fetch
in favor of the options from (1)python-fetch
in favor of apython-downloads
settingnever
variant to the enum, allowing even explicit installs to be disabled via the configuration fileTest plan
I tested this with various
pyproject.toml
-level settings anduv venv --preview --python 3.12.2
anduv python install 3.12.2
with and without the new CLI flags.