Remove build backend parking breaks #11576
Draft
+28
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to make it easier for users to try the build backend, so we add `UV_PREVIEW=1`
|
much appreciated! |
zanieb
reviewed
Feb 17, 2025
| __all__ = [ | ||
| "find_uv_bin", | ||
| # PEP 517 hook `build_sdist`. | ||
| "build_sdist", |
There was a problem hiding this comment.
Does this preclude us from moving these into a separate namespace later? (as discussed elsewhere)
zanieb
reviewed
Feb 17, 2025
Comment on lines
25
to
+34
| def warn_config_settings(config_settings: "Mapping[Any, Any] | None" = None) -> None: | ||
| import os | ||
| import sys | ||
|
|
||
| if not os.environ.get("UV_PREVIEW"): | ||
| print( | ||
| "Warning: The uv build backend is in preview. " | ||
| "Set the `UV_PREVIEW` environment variable to `1` to acknowledge.", | ||
| file=sys.stderr, | ||
| ) |
There was a problem hiding this comment.
It's kind of weird to have this in warn_config_settings?
zanieb
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to make it easier for users to try the build backend, so we allow using the build backend without requiring
UV_PREVIEW=1. Instead, we only print a note about the preview status of the build backend. This improves using packages with the uv build backend with other PEP 517 frontends that don't have uv's--previewflag.