Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow selection of debug build interpreters #11520

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Allow selection of debug build interpreters #11520

wants to merge 1 commit into from

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Feb 14, 2025

Extends the PythonVariant logic to support interpreters with the debug flag enabled.

@zanieb zanieb added the enhancement New feature or improvement to existing functionality label Feb 14, 2025
Self::Freethreaded => "t",
Self::FreethreadedDebug => "td",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to confirm it's td and not dt still.

----- stdout -----

----- stderr -----
error: No download found for request: cpython-3.13d-[PLATFORM]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think something is wrong with generate-download-metadata.py because this download should exist.

@zanieb
Copy link
Member Author

zanieb commented Feb 14, 2025

A couple notes on things to do

  • uv python list should probably not show downloads for these by default
  • Parsing needs to be implemented in download request keys e.g. uv python install cpython-3.10.2+debug-macos-aarch64-none
  • Ensure uv python find works for existing interpreters with debug enabled

@@ -660,6 +660,79 @@ fn python_install_freethreaded() {
"###);
}

#[test]
fn python_install_debug() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied the freethreaded test to start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant