Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compile_enumerate_no_versions snapshot #10998

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Update compile_enumerate_no_versions snapshot #10998

merged 1 commit into from
Jan 27, 2025

Conversation

charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Jan 27, 2025

Summary

I think the "available versions" may not filter on --exclude-newer, since it's marked as an incompatibility? In which case, this error message can change as versions are published.

@charliermarsh charliermarsh added the testing Internal testing of behavior label Jan 27, 2025
@charliermarsh charliermarsh requested a review from zanieb January 27, 2025 18:54
@zanieb
Copy link
Member

zanieb commented Jan 27, 2025

That doesn't sound right — we explicitly treat unavailable versions due to exclude newer as entirely missing during error messaging for reproducibility.

@zanieb
Copy link
Member

zanieb commented Jan 27, 2025

// If candidate is not compatible due to exclude newer, continue searching.
// This is a special case — we pretend versions with exclude newer incompatibilities
// do not exist so that they are not present in error messages in our test suite.
// TODO(zanieb): Now that `--exclude-newer` is user facing we may want to consider
// flagging this behavior such that we _will_ report filtered distributions due to
// exclude-newer in our error messages.
if matches!(
candidate.dist(),
CandidateDist::Incompatible(
IncompatibleDist::Source(IncompatibleSource::ExcludeNewer(_))
| IncompatibleDist::Wheel(IncompatibleWheel::ExcludeNewer(_))
)
) {
continue;
}

@zanieb
Copy link
Member

zanieb commented Jan 27, 2025

but I guess it's possible it manifests still somehow?

@charliermarsh
Copy link
Member Author

Yeah, but this is based on available_versions? And available_versions is populated by versions_response.

@zanieb
Copy link
Member

zanieb commented Jan 27, 2025

I see, that makes sense I think.

@charliermarsh
Copy link
Member Author

I can fix it at some point (even later today), I just want to get this passing to unblock.

@charliermarsh charliermarsh merged commit c88a4ba into main Jan 27, 2025
73 checks passed
@charliermarsh charliermarsh deleted the charlie/t branch January 27, 2025 19:18
styvane added a commit to styvane/uv that referenced this pull request Jan 29, 2025
* main: (22 commits)
  fix async windows file persist retries (astral-sh#11008)
  Respect `--no-sources` for `uv pip install` workspace discovery (astral-sh#11003)
  Remove unnecessary distribution clone (astral-sh#11004)
  Properly format test publish error (astral-sh#11001)
  Reject `--editable` flag on non-directory requirements (astral-sh#10994)
  Add a troubleshooting section and reproducible example guide (astral-sh#10947)
  Update documentation for activating virtual environments in different shell (astral-sh#11000)
  Improve publish test script resilience (astral-sh#10984)
  Update `compile_enumerate_no_versions ` snapshot (astral-sh#10998)
  Reference workspaces in `--no-sources` documentation (astral-sh#10995)
  [docs/integration/docker] add sha pinning tip (astral-sh#10955)
  Update name of "Build binary" job to highlight that these are the "release" binaries (astral-sh#10990)
  Use install action for cargo shear (astral-sh#10983)
  Update Rust crate rustix to v0.38.44 (astral-sh#10974)
  Update Rust crate fs-err to v3.1.0 (astral-sh#10976)
  Update pre-commit hook astral-sh/ruff-pre-commit to v0.9.3 (astral-sh#10975)
  Update Rust crate rkyv to v0.8.10 (astral-sh#10973)
  Update Rust crate jiff to v0.1.27 (astral-sh#10972)
  Update Rust crate insta to v1.42.1 (astral-sh#10971)
  Update Rust crate clap to v4.5.27 (astral-sh#10970)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Internal testing of behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants