Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to anstream for colors #782

Closed
konstin opened this issue Jan 4, 2024 · 4 comments · Fixed by #823
Closed

Migrate to anstream for colors #782

konstin opened this issue Jan 4, 2024 · 4 comments · Fixed by #823
Assignees
@charliermarsh
Labels
internal A refactor or improvement that is not user-facing

Comments

@konstin
Copy link
Member

konstin commented Jan 4, 2024

Followup to #742.
@charliermarsh
Copy link
Member

I think anstream itself doesn't do colors, it does the println / writeable stream, and it integrates with styling crates like owo-colors.

@BurntSushi
Copy link
Member

I would check to see what Cargo is using for colors these days.

@konstin
Copy link
Member Author

konstin commented Jan 4, 2024

anstream and color-print rust-lang/cargo#12751

@BurntSushi
Copy link
Member

Looks like anstream and color-print?

@charliermarsh charliermarsh self-assigned this Jan 6, 2024
@charliermarsh charliermarsh mentioned this issue Jan 7, 2024
Merged
@charliermarsh charliermarsh added the internal A refactor or improvement that is not user-facing label Jan 7, 2024
charliermarsh added a commit that referenced this issue Jan 7, 2024
@charliermarsh
Use anstream for all color control (#823)
e6fcb9c 
## Summary

We can use `anstream` for all color control, rather than going through
`colored`. Note that we still need the `colored` crate, since `colored`
and `anstream` solve different problems. (`anstream` recommends using
`owo-colors` alongside it, but `colored` seems to work fine?)

Resolves the issue raised in
#742 via `anstream` rather than
`colored`.

Closes #782.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliermarsh charliermarsh

Labels
internal A refactor or improvement that is not user-facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use anstream for all color control astral-sh/uv
3 participants
@BurntSushi @charliermarsh @konstin