-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test coverage for multi-index scenarios for uv.lock
#5882
Comments
konstin
added a commit
that referenced
this issue
Aug 7, 2024
Currently, we're repeating the same `source` line for every package, so the lockfiles have a lot of: ```toml source = { registry = "https://pypi.org/simple" } ``` This PR introduces a top level `default-source` entry set to the default index URL, if any. When the source matches, we don't repeat the `source` entry. This reduces the number of lines in `uv.lock` noticeably across the board: * A small data science project: 421 -> 394 * A small bot: 455 -> 426 * Transformers: 5683 -> 5419 * Warehouse: 4632 -> 4306 * Airflow: 2709 -> 2576 Caveat: We don't have good multi-index coverage (#5882). 3/3 for #4893
konstin
added a commit
that referenced
this issue
Aug 7, 2024
Currently, we're repeating the same `source` line for every package, so the lockfiles have a lot of: ```toml source = { registry = "https://pypi.org/simple" } ``` This PR introduces a top level `default-source` entry set to the default index URL, if any. When the source matches, we don't repeat the `source` entry. This reduces the number of lines in `uv.lock` noticeably across the board: * A small data science project: 421 -> 394 * A small bot: 455 -> 426 * Transformers: 5683 -> 5419 * Warehouse: 4632 -> 4306 * Airflow: 2709 -> 2576 Caveat: We don't have good multi-index coverage (#5882). 3/3 for #4893
konstin
added a commit
that referenced
this issue
Aug 7, 2024
Currently, we're repeating the same `source` line for every package, so the lockfiles have a lot of: ```toml source = { registry = "https://pypi.org/simple" } ``` This PR introduces a top level `default-source` entry set to the default index URL, if any. When the source matches, we don't repeat the `source` entry. This reduces the number of lines in `uv.lock` noticeably across the board: * A small data science project: 421 -> 394 * A small bot: 455 -> 426 * Transformers: 5683 -> 5419 * Warehouse: 4632 -> 4306 * Airflow: 2709 -> 2576 Caveat: We don't have good multi-index coverage (#5882). 3/3 for #4893
konstin
added a commit
that referenced
this issue
Aug 8, 2024
Currently, we're repeating the same `source` line for every package, so the lockfiles have a lot of: ```toml source = { registry = "https://pypi.org/simple" } ``` This PR introduces a top level `default-source` entry set to the default index URL, if any. When the source matches, we don't repeat the `source` entry. This reduces the number of lines in `uv.lock` noticeably across the board: * A small data science project: 421 -> 394 * A small bot: 455 -> 426 * Transformers: 5683 -> 5419 * Warehouse: 4632 -> 4306 * Airflow: 2709 -> 2576 Caveat: We don't have good multi-index coverage (#5882). 3/3 for #4893
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, there is only one scenarios for the lockfile with multiple registries (
add_lower_bound_local
) and that is testing something else. We should add at least a basic test for multi-index cases.The text was updated successfully, but these errors were encountered: