Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support s390x and powerpc #289

Merged
merged 1 commit into from
Feb 15, 2025
Merged

feat: support s390x and powerpc #289

merged 1 commit into from
Feb 15, 2025

Conversation

Zxilly
Copy link
Contributor

@Zxilly Zxilly commented Feb 15, 2025

This patch adds support for s390x and powerpc.

According https://github.com/nodejs/node/blob/main/BUILDING.md#platform-list , only powerpcle available on Linux. So we always use uv-powerpc64le-unknown-linux-gnu

@Zxilly Zxilly requested a review from eifinger as a code owner February 15, 2025 18:54
@eifinger
Copy link
Collaborator

eifinger commented Feb 15, 2025

According to https://docs.github.com/en/actions/hosting-your-own-runners/managing-self-hosted-runners/about-self-hosted-runners#architectures those are not supported architectures for GitHub Action runners. Am I missing something?

@Zxilly
Copy link
Contributor Author

Zxilly commented Feb 15, 2025

IBM has written a fork that supports s390x, and there seems to be some work to support it on the main branch as well.

While writing this patch, I added powerpc support by the way, as I noticed that uv provides pre-builds for these platforms.

@eifinger
Copy link
Collaborator

IBM has written a fork that supports s390x, and there seems to be some work to support it on the main branch as well.

While writing this patch, I added powerpc support by the way, as I noticed that uv provides pre-builds for these platforms.

Thank you for the insight. Is this fork public and can you share a link? Also, do you have a running infrastructure available where you can test this on? This would help a lot in making sure we are releasing high quality.

@eifinger eifinger added the enhancement New feature or request label Feb 15, 2025
@Zxilly
Copy link
Contributor Author

Zxilly commented Feb 15, 2025

I have deployed this fork on my own project, check out the https://github.com/Zxilly/go-size-analyzer/blob/5e0591e1219e2af888c74d7e5e3e9f0bbe7585d2/.github/actions/setup-script/action.yml#L26

It works as expected, shown in https://github.com/Zxilly/go-size-analyzer/actions/runs/13348482963/job/37281949011 , the self-hosted runner is a s390x runner.

@Zxilly
Copy link
Contributor Author

Zxilly commented Feb 15, 2025

The runner fork was at https://github.com/anup-kodlekere/gaplib . There's some patches in build-files

@eifinger
Copy link
Collaborator

Thank you for your contribution!

@eifinger eifinger merged commit bb8d247 into astral-sh:main Feb 15, 2025
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants