Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add external option to unused-noqa documentation #8171

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Oct 24, 2023

No description provided.

@zanieb zanieb added the documentation Improvements or additions to documentation label Oct 24, 2023
@@ -35,6 +35,9 @@ pub struct UnusedCodes {
/// foo.bar()
/// ```
///
/// ## Options
/// - `external`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this be hyperlinked automatically?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think it happens during our documentation generation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then this PR is...

approved gif

@github-actions
Copy link
Contributor

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

@zanieb zanieb merged commit 2d0769e into main Oct 24, 2023
17 checks passed
@zanieb zanieb deleted the zanie/unused-external branch October 24, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants