Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade LibCST to support Python 3.12 #7764

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Upgrade LibCST to support Python 3.12 #7764

merged 1 commit into from
Oct 2, 2023

Conversation

charliermarsh
Copy link
Member

Summary

We'll revert back to the crates.io release once it's up-to-date, but better to get this out now that Python 3.12 is released.

Test Plan

cargo test

@charliermarsh charliermarsh force-pushed the charlie/libcst branch 2 times, most recently from 319a476 to e7324d9 Compare October 2, 2023 15:04
@charliermarsh charliermarsh added the internal An internal refactor or improvement label Oct 2, 2023
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 2, 2023

CodSpeed Performance Report

Merging #7764 will degrade performances by 2.09%

Comparing charlie/libcst (e7324d9) with main (bdf2852)

Summary

❌ 1 regressions
✅ 24 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main charlie/libcst Change
linter/default-rules[pydantic/types.py] 38.1 ms 38.9 ms -2.09%

@charliermarsh charliermarsh requested a review from konstin October 2, 2023 15:26
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

@charliermarsh charliermarsh merged commit 75f759e into main Oct 2, 2023
@charliermarsh charliermarsh deleted the charlie/libcst branch October 2, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants