Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge subsettings when extending configurations #4431

Merged
merged 6 commits into from
May 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions crates/ruff/src/rules/flake8_annotations/settings.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,11 @@

use serde::{Deserialize, Serialize};

use ruff_macros::CacheKey;
use ruff_macros::ConfigurationOptions;
use ruff_macros::{CacheKey, CombineOptions, ConfigurationOptions};

#[derive(Debug, PartialEq, Eq, Default, Serialize, Deserialize, ConfigurationOptions)]
#[derive(
Debug, PartialEq, Eq, Default, Serialize, Deserialize, ConfigurationOptions, CombineOptions,
)]
#[serde(
deny_unknown_fields,
rename_all = "kebab-case",
Expand Down
6 changes: 4 additions & 2 deletions crates/ruff/src/rules/flake8_bandit/settings.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,17 @@

use serde::{Deserialize, Serialize};

use ruff_macros::{CacheKey, ConfigurationOptions};
use ruff_macros::{CacheKey, CombineOptions, ConfigurationOptions};

fn default_tmp_dirs() -> Vec<String> {
["/tmp", "/var/tmp", "/dev/shm"]
.map(std::string::ToString::to_string)
.to_vec()
}

#[derive(Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions)]
#[derive(
Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions, CombineOptions,
)]
#[serde(
deny_unknown_fields,
rename_all = "kebab-case",
Expand Down
6 changes: 4 additions & 2 deletions crates/ruff/src/rules/flake8_bugbear/settings.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@

use serde::{Deserialize, Serialize};

use ruff_macros::{CacheKey, ConfigurationOptions};
use ruff_macros::{CacheKey, CombineOptions, ConfigurationOptions};

#[derive(Debug, PartialEq, Eq, Default, Serialize, Deserialize, ConfigurationOptions)]
#[derive(
Debug, PartialEq, Eq, Default, Serialize, Deserialize, ConfigurationOptions, CombineOptions,
)]
#[serde(
deny_unknown_fields,
rename_all = "kebab-case",
Expand Down
6 changes: 4 additions & 2 deletions crates/ruff/src/rules/flake8_builtins/settings.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@

use serde::{Deserialize, Serialize};

use ruff_macros::{CacheKey, ConfigurationOptions};
use ruff_macros::{CacheKey, CombineOptions, ConfigurationOptions};

#[derive(Debug, PartialEq, Eq, Default, Serialize, Deserialize, ConfigurationOptions)]
#[derive(
Debug, PartialEq, Eq, Default, Serialize, Deserialize, ConfigurationOptions, CombineOptions,
)]
#[serde(
deny_unknown_fields,
rename_all = "kebab-case",
Expand Down
6 changes: 4 additions & 2 deletions crates/ruff/src/rules/flake8_comprehensions/settings.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@

use serde::{Deserialize, Serialize};

use ruff_macros::{CacheKey, ConfigurationOptions};
use ruff_macros::{CacheKey, CombineOptions, ConfigurationOptions};

#[derive(Debug, PartialEq, Eq, Default, Serialize, Deserialize, ConfigurationOptions)]
#[derive(
Debug, PartialEq, Eq, Default, Serialize, Deserialize, ConfigurationOptions, CombineOptions,
)]
#[serde(
deny_unknown_fields,
rename_all = "kebab-case",
Expand Down
6 changes: 4 additions & 2 deletions crates/ruff/src/rules/flake8_errmsg/settings.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@

use serde::{Deserialize, Serialize};

use ruff_macros::{CacheKey, ConfigurationOptions};
use ruff_macros::{CacheKey, CombineOptions, ConfigurationOptions};

#[derive(Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions)]
#[derive(
Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions, CombineOptions,
)]
#[serde(
deny_unknown_fields,
rename_all = "kebab-case",
Expand Down
6 changes: 4 additions & 2 deletions crates/ruff/src/rules/flake8_gettext/settings.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
use serde::{Deserialize, Serialize};

use ruff_macros::{CacheKey, ConfigurationOptions};
use ruff_macros::{CacheKey, CombineOptions, ConfigurationOptions};

#[derive(Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions)]
#[derive(
Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions, CombineOptions,
)]
#[serde(
deny_unknown_fields,
rename_all = "kebab-case",
Expand Down
6 changes: 4 additions & 2 deletions crates/ruff/src/rules/flake8_implicit_str_concat/settings.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@

use serde::{Deserialize, Serialize};

use ruff_macros::{CacheKey, ConfigurationOptions};
use ruff_macros::{CacheKey, CombineOptions, ConfigurationOptions};

#[derive(Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions)]
#[derive(
Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions, CombineOptions,
)]
#[serde(
deny_unknown_fields,
rename_all = "kebab-case",
Expand Down
6 changes: 4 additions & 2 deletions crates/ruff/src/rules/flake8_import_conventions/settings.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
use rustc_hash::{FxHashMap, FxHashSet};
use serde::{Deserialize, Serialize};

use ruff_macros::{CacheKey, ConfigurationOptions};
use ruff_macros::{CacheKey, CombineOptions, ConfigurationOptions};

const CONVENTIONAL_ALIASES: &[(&str, &str)] = &[
("altair", "alt"),
Expand All @@ -20,7 +20,9 @@ const CONVENTIONAL_ALIASES: &[(&str, &str)] = &[
("pyarrow", "pa"),
];

#[derive(Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions)]
#[derive(
Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions, CombineOptions,
)]
#[serde(
deny_unknown_fields,
rename_all = "kebab-case",
Expand Down
6 changes: 4 additions & 2 deletions crates/ruff/src/rules/flake8_pytest_style/settings.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

use serde::{Deserialize, Serialize};

use ruff_macros::{CacheKey, ConfigurationOptions};
use ruff_macros::{CacheKey, CombineOptions, ConfigurationOptions};

use super::types;

Expand All @@ -20,7 +20,9 @@ fn default_broad_exceptions() -> Vec<String> {
.to_vec()
}

#[derive(Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions)]
#[derive(
Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions, CombineOptions,
)]
#[serde(
deny_unknown_fields,
rename_all = "kebab-case",
Expand Down
6 changes: 4 additions & 2 deletions crates/ruff/src/rules/flake8_quotes/settings.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

use serde::{Deserialize, Serialize};

use ruff_macros::{CacheKey, ConfigurationOptions};
use ruff_macros::{CacheKey, CombineOptions, ConfigurationOptions};

#[derive(Debug, Copy, Clone, PartialEq, Eq, Serialize, Deserialize, CacheKey)]
#[serde(deny_unknown_fields, rename_all = "kebab-case")]
Expand All @@ -20,7 +20,9 @@ impl Default for Quote {
}
}

#[derive(Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions)]
#[derive(
Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions, CombineOptions,
)]
#[serde(
deny_unknown_fields,
rename_all = "kebab-case",
Expand Down
6 changes: 4 additions & 2 deletions crates/ruff/src/rules/flake8_self/settings.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,15 @@

use serde::{Deserialize, Serialize};

use ruff_macros::{CacheKey, ConfigurationOptions};
use ruff_macros::{CacheKey, CombineOptions, ConfigurationOptions};

// By default, ignore the `namedtuple` methods and attributes, which are underscore-prefixed to
// prevent conflicts with field names.
const IGNORE_NAMES: [&str; 5] = ["_make", "_asdict", "_replace", "_fields", "_field_defaults"];

#[derive(Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions)]
#[derive(
Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions, CombineOptions,
)]
#[serde(
deny_unknown_fields,
rename_all = "kebab-case",
Expand Down
6 changes: 4 additions & 2 deletions crates/ruff/src/rules/flake8_tidy_imports/options.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,15 @@
use rustc_hash::FxHashMap;
use serde::{Deserialize, Serialize};

use ruff_macros::ConfigurationOptions;
use ruff_macros::{CombineOptions, ConfigurationOptions};

use super::banned_api::ApiBan;
use super::relative_imports::Strictness;
use super::Settings;

#[derive(Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions)]
#[derive(
Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions, CombineOptions,
)]
#[serde(
deny_unknown_fields,
rename_all = "kebab-case",
Expand Down
6 changes: 4 additions & 2 deletions crates/ruff/src/rules/flake8_type_checking/settings.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@

use serde::{Deserialize, Serialize};

use ruff_macros::{CacheKey, ConfigurationOptions};
use ruff_macros::{CacheKey, CombineOptions, ConfigurationOptions};

#[derive(Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions)]
#[derive(
Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions, CombineOptions,
)]
#[serde(
deny_unknown_fields,
rename_all = "kebab-case",
Expand Down
6 changes: 4 additions & 2 deletions crates/ruff/src/rules/flake8_unused_arguments/settings.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@

use serde::{Deserialize, Serialize};

use ruff_macros::{CacheKey, ConfigurationOptions};
use ruff_macros::{CacheKey, CombineOptions, ConfigurationOptions};

#[derive(Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions)]
#[derive(
Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions, CombineOptions,
)]
#[serde(
deny_unknown_fields,
rename_all = "kebab-case",
Expand Down
6 changes: 4 additions & 2 deletions crates/ruff/src/rules/isort/settings.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ use rustc_hash::{FxHashMap, FxHashSet};
use serde::{Deserialize, Serialize};
use strum::IntoEnumIterator;

use ruff_macros::{CacheKey, ConfigurationOptions};
use ruff_macros::{CacheKey, CombineOptions, ConfigurationOptions};

use crate::rules::isort::categorize::KnownModules;
use crate::rules::isort::ImportType;
Expand All @@ -33,7 +33,9 @@ impl Default for RelativeImportsOrder {
}
}

#[derive(Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions)]
#[derive(
Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions, CombineOptions,
)]
#[serde(
deny_unknown_fields,
rename_all = "kebab-case",
Expand Down
6 changes: 4 additions & 2 deletions crates/ruff/src/rules/mccabe/settings.rs
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
//! Settings for the `mccabe` plugin.

use ruff_macros::{CacheKey, ConfigurationOptions};
use ruff_macros::{CacheKey, CombineOptions, ConfigurationOptions};
use serde::{Deserialize, Serialize};

#[derive(Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions)]
#[derive(
Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions, CombineOptions,
)]
#[serde(
deny_unknown_fields,
rename_all = "kebab-case",
Expand Down
6 changes: 4 additions & 2 deletions crates/ruff/src/rules/pep8_naming/settings.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
//! Settings for the `pep8-naming` plugin.

use ruff_macros::{CacheKey, ConfigurationOptions};
use ruff_macros::{CacheKey, CombineOptions, ConfigurationOptions};
use serde::{Deserialize, Serialize};

const IGNORE_NAMES: [&str; 12] = [
Expand All @@ -18,7 +18,9 @@ const IGNORE_NAMES: [&str; 12] = [
"maxDiff",
];

#[derive(Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions)]
#[derive(
Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions, CombineOptions,
)]
#[serde(
deny_unknown_fields,
rename_all = "kebab-case",
Expand Down
6 changes: 4 additions & 2 deletions crates/ruff/src/rules/pycodestyle/settings.rs
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
//! Settings for the `pycodestyle` plugin.

use ruff_macros::{CacheKey, ConfigurationOptions};
use ruff_macros::{CacheKey, CombineOptions, ConfigurationOptions};
use serde::{Deserialize, Serialize};

#[derive(Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions)]
#[derive(
Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions, CombineOptions,
)]
#[serde(deny_unknown_fields, rename_all = "kebab-case", rename = "Pycodestyle")]
#[cfg_attr(feature = "schemars", derive(schemars::JsonSchema))]
pub struct Options {
Expand Down
6 changes: 4 additions & 2 deletions crates/ruff/src/rules/pydocstyle/settings.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
//! Settings for the `pydocstyle` plugin.

use crate::registry::Rule;
use ruff_macros::{CacheKey, ConfigurationOptions};
use ruff_macros::{CacheKey, CombineOptions, ConfigurationOptions};
use serde::{Deserialize, Serialize};
use std::collections::BTreeSet;

Expand Down Expand Up @@ -68,7 +68,9 @@ impl Convention {
}
}

#[derive(Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions)]
#[derive(
Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions, CombineOptions,
)]
#[serde(deny_unknown_fields, rename_all = "kebab-case", rename = "Pydocstyle")]
#[cfg_attr(feature = "schemars", derive(schemars::JsonSchema))]
pub struct Options {
Expand Down
6 changes: 4 additions & 2 deletions crates/ruff/src/rules/pylint/settings.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
//! Settings for the `pylint` plugin.

use anyhow::anyhow;
use ruff_macros::{CacheKey, ConfigurationOptions};
use ruff_macros::{CacheKey, CombineOptions, ConfigurationOptions};
use rustpython_parser::ast::Constant;
use serde::{Deserialize, Serialize};

Expand Down Expand Up @@ -35,7 +35,9 @@ impl TryFrom<&Constant> for ConstantType {
}
}

#[derive(Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions)]
#[derive(
Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions, CombineOptions,
)]
#[serde(
deny_unknown_fields,
rename_all = "kebab-case",
Expand Down
Loading